Brijesh619 commented on code in PR #688: URL: https://github.com/apache/atlas/pull/688#discussion_r3923349114
########## dashboard/src/components/__tests__/EntityDisplayImage.test.tsx: ########## @@ -15,269 +15,169 @@ * limitations under the License. */ Review Comment: I've gone through the checklist and ensured all these cases are now tested: Trees do not unmount: Added a test documenting the remount behavior between the wrapper and popover. Version data retained: Covered in sessionSlice.test.ts. Missing guid guard: Covered by a negative test in EntityDisplayImage.test.tsx. TreeSkeletonLoader edge cases: Added negative/undefined bounds tests in TreeSkeletonLoader.test.tsx. Escape key behavior: Explicitly tested in SideBarBody.test.tsx. Popover height snapping: Added a new test validating the max height calculation when near the bottom of the viewport. relationshipSearch=false negative test: Covered in SideBarBody.test.tsx verifying the tree is completely removed from the DOM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
