mneethiraj commented on code in PR #731:
URL: https://github.com/apache/atlas/pull/731#discussion_r3909470494


##########
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java:
##########
@@ -654,31 +654,40 @@ private void processEdge(final AtlasEdge edge, final 
Map<String, AtlasEntityHead
         String      relationGuid = AtlasGraphUtilsV2.getEncodedProperty(edge, 
RELATIONSHIP_GUID_PROPERTY_KEY, String.class);
         boolean     isInputEdge  = 
edge.getLabel().equalsIgnoreCase(PROCESS_INPUTS_EDGE);
 
-        if (!entities.containsKey(inGuid)) {
-            AtlasEntityHeader entityHeader = 
entityRetriever.toAtlasEntityHeader(inVertex);
+        addEntityHeaderIfAuthorized(inVertex, inGuid, entities);

Review Comment:
   Instead of `skipping` entities as encountered while retrieving the lineage, 
I suggest gathering entire lineage details in `AtlasLineageInfo` and 
`scrubbing` it - similar to search result scrubbing in 
`EntityDiscoveryService.scrubSearchResults()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to