Hello, everyone.

I don't know if I can comment here.
As a new contributor, I'm in favor of option 2.

* Until recently, I didn't know that the <!-- --> part need to delete.
  So, "Please remove this line and the above text before creating your
pull request." is important.
  (I just wanted to let you know this.)
* I thought it would be nice to have a page[1] like this instead of
<!-- -->comments.

[1] https://gist.github.com/hiroyuki-sato/f7eebe69c3255028027f701240b77a20

Regards

--
Hiroyuki Sato

2025年2月17日(月) 18:26 Saurabh Singh <singh1203...@gmail.com>:
>
> Hi Kou,
>
> 2. Keep minimal notes as a normal text not a comment
> >    something like:
> >    ----
> >    Thanks for opening a pull request!
> >
> >    If this is your first pull request you can find detailed
> >    information on how to contribute here:
> >
> >    * [New Contributor's Guide](
> > https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request
> > )
> >    * [Contributing Overview](
> > https://arrow.apache.org/docs/dev/developers/overview.html)
> >
> >    Please remove this line and the above text before creating your pull
> > request.
> >
> >    ### Rationale for this change
> >
> >    ### What changes are included in this PR?
> >
> >    ### Are these changes tested?
> >
> >    ### Are there any user-facing changes?
> >    ----
>
>
> I'm even in the favour of option 2.
>
> Regards
> Saurabh



-- 
Hiroyuki Sato

Reply via email to