I’ve commented on that PR [1] one issue I saw (us possibly overloading the CMAKE env var).
As for CRAN: we have/use whatever is on the machines doing the building. We do download newer cmake if it’s required (and our internet isn’t blocked) for all builds except for Windows. The windows failure on that PR is indicating that the cmake in the RTools toolchain is too old there for that version. IIUC RTools 4.3 does have cmake > 3.25 RTools 4.2 does not [2]. We download binaries on windows when building on CRAN, so we might be ok to bump to a higher cmake version than what’s provided in RTools, but we would need to add it to our build infrastructure to produce binaries for folks (+CRAN) to use. [1] https://github.com/apache/arrow/pull/44989 [2] https://cran.r-project.org/bin/windows/Rtools/rtools43/news.html > On Dec 11, 2024, at 11:28, Raúl Cumplido <rau...@apache.org> wrote: > > I've started an exploratory PR to find potential issues around bumping > CMake to 3.25 [1]. > > There is currently an issue with the R builds, I am unsure on how the CRAN > release works but does CRAN force on a specific CMake version? Could this > be a problem? > > Regards, > Raúl > > [1] https://github.com/apache/arrow/pull/44989 > > El mar, 10 dic 2024 a las 15:36, Gang Wu (<ust...@gmail.com>) escribió: > >> +1 >> >> I'm excited to use new features of CMake. >> >> On Tue, Dec 10, 2024 at 6:02 PM Raúl Cumplido <rau...@apache.org> wrote: >> >>> I am also +1 on bumping the CMake version to 3.25 >>> >>> El mar, 10 dic 2024 a las 3:36, wish maple (<maplewish...@gmail.com>) >>> escribió: >>> >>>> +1 on 3.25 >>>> >>>> Best, >>>> Xuwei Fu >>>> >>>> Ruoxi Sun <zanmato1...@gmail.com> 于2024年12月10日周二 08:36写道： >>>> >>>>> I would +1 on 3.25. >>>>> >>>>> Thanks kou for driving this. >>>>> >>>>> *Regards,* >>>>> *Rossi SUN* >>>>> >>>>> >>>>> On Tue, Dec 10, 2024 at 7:41 AM Jacob Wujciak-Jens <ja...@wujciak.de >>> >>>>> wrote: >>>>> >>>>>> +1 on 3.25 >>>>>> >>>>>> Thanks for the summary kou. >>>>>> >>>>>> Am Mo., 9. Dez. 2024 um 23:02 Uhr schrieb Marcus Hanwell >>>>>> <mar...@voltrondata.com.invalid>: >>>>>>> >>>>>>> I would push pretty strongly for 3.25 for the extra features. It >>>> would >>>>>>> enable much more modern, compact CMake code. >>>>>>> >>>>>>> On Mon, Dec 9, 2024 at 4:11 PM Sutou Kouhei <k...@clear-code.com> >>>>> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> Currently, we require CMake 3.16 or later: >>>>>>>> >>>>>>>> >>>>>> >>>>> >>>> >>> >> https://github.com/apache/arrow/blob/e0f8c5e8e6f8b328a997f7e21bc6fd1a01b3b3fd/cpp/CMakeLists.txt#L18 >>>>>>>> >>>>>>>>> cmake_minimum_required(VERSION 3.16) >>>>>>>> >>>>>>>> We want to bump required CMake version to use newer >>>>>>>> features. We can improve our CMake configurations with them: >>>>>>>> https://github.com/apache/arrow/issues/44950 >>>>>>>> >>>>>>>> What version should we require? >>>>>>>> >>>>>>>> Here are CMake versions on supported Linux platforms: >>>>>>>> >>>>>>>> * Ubuntu 20.04 (CMake 3.16) will reach EOL on 2025-04: >>>>>>>> https://wiki.ubuntu.com/Releases >>>>>>>> * CentOS 7 (CMake 3.17) reached EOL: We're still supporting >>>>>>>> CentOS 7[1] but we don't need to care about CentOS 7 for >>>>>>>> this. We can install newer CMake manually. >>>>>>>> [1] >>>>>> https://github.com/apache/arrow/pull/41395#issuecomment-2116223200 >>>>>>>> * Debian GNU/Linux bullseye (CMake 3.18) reached EOL on >>>>>>>> 2024-08-14: https://wiki.debian.org/DebianReleases >>>>>>>> * Debian GNU/Linux bookworm provides CMake 3.25: >>>>>>>> https://packages.debian.org/search?keywords=cmake >>>>>>>> * Ubuntu 22.04 provides CMake 3.22: >>>>>>>> https://packages.ubuntu.com/search?keywords=cmake >>>>>>>> * AlmaLinux 8 provides CMake 3.26 >>>>>>>> * AlmaLinux 9 provides CMake 3.26 >>>>>>>> >>>>>>>> (Multi-platform packaging systems such ad Homebrew, vcpkg, >>>>>>>> conda and so on provide newer CMake. So we don't need to >>>>>>>> care about them.) >>>>>>>> >>>>>>>> >>>>>>>> There are some proposals: >>>>>>>> >>>>>>>> * We require CMake 3.25 or later because there are some >>>>>>>> useful features in CMake 3.25. Ubuntu 22.04 users must >>>>>>>> install newer CMake manually. >>>>>>>> * We require CMake 3.22 or later. All supported Linux >>>>>>>> platforms can use system CMake. >>>>>>>> >>>>>>>> >>>>>>>> If you have any opinion, concern and so on, please share it. >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> -- >>>>>>>> kou >>>>>>>> >>>>>> >>>>> >>>> >>> >>
