Good to know, thanks for clarifying the reasoning Kou! :) On Sun, 3 Nov 2024, 02:25 Sutou Kouhei, <k...@clear-code.com> wrote:
> Hi Nic, > > I think that replacing the C++ binaries for 18.0.0 doesn't > affect 18.0.1 release. > > The current wrong 18.0.0 C++ binaries are "official" > release. (We voted them.) The correct 18.0.0 C++ binaries > are "unofficial" because we don't vote them. So we can't the > correct ones to > https://apache.jfrog.io/ui/native/arrow/r/X.Y.Z/ . We need > to vote the correct 18.0.0 C++ binaries or 18.0.1 release. > The former is an irregular process. So the latter may be > easier. > > > It may be better that the Arrow R package may wait for > 18.0.1 (or 18.1.0) if we haven't submitted it to CRAN yet. > > > BTW, can we change the C++ binaries location to > https://github.com/apache/arrow/releases/tag/apache-arrow-X.Y.Z > something like > https://github.com/apache/arrow/releases/tag/apache-arrow-18.0.0 > from > https://apache.jfrog.io/ui/native/arrow/r/X.Y.Z/ > something like > https://apache.jfrog.io/ui/native/arrow/r/18.0.0/ ? > > Our Artifactory space uses 75% of quota. So it sends > notification e-mails periodically... > > > Thanks, > -- > kou > > In <caft6oobuxhqbf_cjzqipvvmqtox9uf8evd1khp_7ogzt_kd...@mail.gmail.com> > "Re: 18.0.1 release manager" on Fri, 1 Nov 2024 06:11:26 +0000, > Nic Crane <thisis...@gmail.com> wrote: > > > Hi Kou, > > > > The Arrow R package is still in the process of being submitted to CRAN, > so > > if it helps and could reduce the work needed for 18.0.1 could we replace > > the C++ binaries with the correct ones? > > > > Thanks, > > > > Nic > > > > On Fri, 1 Nov 2024, 00:26 Sutou Kouhei, <k...@clear-code.com> wrote: > > > >> Hi, > >> > >> We built 18.0.0 RC0 binaries with wrong source. The 18.0.0 > >> RC0 source archive was generated from the > >> apache-arrow-18.0.0-rc0 tag[0] but the binaries were built > >> from d0e7d07[1] not the apache-arrow-18.0.0-rc0 tag. It's > >> my fault. Sorry. > >> > >> [0] > https://github.com/apache/arrow/releases/tag/apache-arrow-18.0.0-rc0 > >> [1] https://github.com/apache/arrow/pull/44440#issuecomment-2416557688 > >> > >> I think that we should release 18.0.1. Is there any > >> committer or PMC member who want to volunteer 18.0.1 release > >> manager? I'll help you. (I think we can have multiple > >> release managers for one release to reduce each release > >> manager's cost.) > >> > >> See also > >> https://arrow.apache.org/docs/developers/release.html for > >> release related tasks. > >> > >> In recent years, only some limited contributors worked on > >> our releases. It may be better that we have more > >> contributors working on our releases to keep releasing > >> continuously. > >> > >> > >> FYI: Here are problems of 18.0.0 RC0 binaries: > >> > >> Affected binaries: > >> > >> * Python wheels > >> * Apache Arrow C++ binaries used by the R packages > >> * Java jars > >> * C# NuGets > >> * MATLAB MLTBX > >> > >> Not affected binaries: > >> > >> * deb > >> * RPM > >> > >> Affected details: > >> > >> Python wheels: > >> > >> * pyarrow.cpp_build_info.version is "18.0.0-SNAPSHOT" not "18.0.0" > >> > >> Apache Arrow C++ binaries used by the R packages: > >> > >> * ARROW_VERSION_STRING is "18.0.0-SNAPSHOT" not "18.0.0" > >> (I'm not sure the R bindings have API something like > >> pyarrow.cpp_build_info.version.) > >> > >> Java jars: > >> > >> * Version is "18.0.0-SNAPSHOT" not "18.0.0" > >> * Bump logback.version from 1.5.8 to 1.5.10 > >> * Bump checker.framework.version from 3.48.0 to 3.48.1 > >> (This may not be affected.) > >> * Bump org.cyclonedx:cyclonedx-maven-plugin from 2.8.2 to 2.9.0 > >> (This may not be affected.) > >> * UnionMapWriter supports map() > >> > >> > https://github.com/apache/arrow/commit/7df47483197186b564a9882ac6d1b5f32b2e3d51 > >> > >> C# NuGets: > >> > >> * Version is "18.0.0-SNAPSHOT" not "18.0.0" > >> * Bump Grpc.Tools from 2.66.0 to 2.67.0 > >> * Have a fix of Flight DoExchange incompatibility > >> > >> > https://github.com/apache/arrow/commit/da5a2957accee3ec082199cfa2c305d19d9ada20 > >> > >> MATLAB MLTBX: > >> > >> * Version is "18.0.0-SNAPSHOT" not "18.0.0" > >> > >> > >> Thanks, > >> -- > >> kou > >> >
