Thank you for verifying!

I can't reproduce this with:

# docker run --rm -it debian:sid
# instructions from
https://github.com/apache/arrow-nanoarrow/blob/main/dev/release/README.md#debianubuntu
git clone https://github.com/apache/arrow-nanoarrow.git arrow-nanoarrow
cd arrow-nanoarrow/dev/release
./verify-release-candidate.sh 0.6.0 0

I wonder if jsonlite's serialization is sensitive to locale? I opened
[1] to track.

I am not personally concerned about this since it is a
rarely-if-ever-used feature of the R package; however, I'm also happy
to solve and cut a new RC if anybody feels otherwise!

[1] https://github.com/apache/arrow-nanoarrow/issues/656

On Wed, Oct 9, 2024 at 12:46 AM Sutou Kouhei <k...@clear-code.com> wrote:
>
> Hi,
>
> I got the following R error:
>
> ----
>   [ FAIL 1 | WARN 0 | SKIP 7 | PASS 1494 ]
>
>   == Skipped tests 
> ===============================================================
>   * On CRAN (7)
>
>   == Failed tests 
> ================================================================
>   -- Failure ('test-extension-vctrs.R:115'): serialize_ptype() can roundtrip 
> R objects --
>   unserialize_ptype(jsonlite::serializeJSON(obj, digits = 16)) (`actual`) not 
> identical to `obj` (`expected`).
>
>     `actual`: 0.000000000000000 1.000000000000000 3.141592653589790 NA
>   `expected`: 0.000000000000000 1.000000000000000 3.141592653589793 NA
>
>   [ FAIL 1 | WARN 0 | SKIP 7 | PASS 1494 ]
>   Error: Test failures
>   Execution halted
> * DONE
>
> Status: 1 ERROR, 1 WARNING
> ----
>
> What do you think about this?
>
>
> I ran the following command line on Debian GNU/Linux sid:
>
>   dev/release/verify-release-candidate.sh 0.6.0 0
>
> with:
>
>   * Apache Arrow C++ main
>   * gcc (Debian 13.3.0-2) 13.3.0
>   * R version 4.4.1 (2024-06-14) -- "Race for Your Life"
>   * Python 3.12.4
>
>
> Thanks,
> --
> kou
>
>
> In <CAFb7qScg7LizJibArZ_aPRffbWLBW7Tuddbn=wppyqicxd6...@mail.gmail.com>
>   "[VOTE] Release Apache Arrow nanoarrow 0.6.0" on Tue, 8 Oct 2024 21:30:02 
> -0500,
>   Dewey Dunnington <de...@voltrondata.com.INVALID> wrote:
>
> > Hello,
> >
> > I would like to propose the following release candidate (rc0) of
> > Apache Arrow nanoarrow [0] version 0.6.0. This release consists of 114
> > resolved GitHub issues from 10 contributors [1].
> >
> > This release candidate is based on commit:
> > 33d2c8b973d8f8f424e02ac92ddeaace2a92f8dd [2]
> >
> > The source release rc0 is hosted at [3].
> > The changelog is located at [4].
> >
> > Please download, verify checksums and signatures, run the unit tests,
> > and vote on the release. See [5] for how to validate a release
> > candidate, [6] for a suite of successful verification runs, and [7]
> > for a (preliminary) draft release post.
> >
> > The vote will be open for at least 72 hours.
> >
> > [ ] +1 Release this as Apache Arrow nanoarrow 0.6.0
> > [ ] +0
> > [ ] -1 Do not release this as Apache Arrow nanoarrow 0.6.0 because...
> >
> > [0] https://github.com/apache/arrow-nanoarrow
> > [1] https://github.com/apache/arrow-nanoarrow/milestone/6?closed=1
> > [2] 
> > https://github.com/apache/arrow-nanoarrow/tree/apache-arrow-nanoarrow-0.6.0-rc0
> > [3] 
> > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-nanoarrow-0.6.0-rc0/
> > [4] 
> > https://github.com/apache/arrow-nanoarrow/blob/apache-arrow-nanoarrow-0.6.0-rc0/CHANGELOG.md
> > [5] 
> > https://github.com/apache/arrow-nanoarrow/blob/main/dev/release/README.md
> > [6] https://github.com/apache/arrow-nanoarrow/actions/runs/11243985397
> > [7] https://github.com/apache/arrow-site/pull/545

Reply via email to