+1 (binding)

I ran the following on Debian GNU/Linux sid:

  TEST_DEFAULT=0 \
    TEST_SOURCE=1 \
    LANG=C \
    TZ=UTC \
    JAVA_HOME=/usr/lib/jvm/default-java \
    dev/release/verify-release-candidate.sh 12 4

  TEST_DEFAULT=0 \
    TEST_APT=1 \
    LANG=C \
    dev/release/verify-release-candidate.sh 12 4

  TEST_DEFAULT=0 \
    TEST_BINARY=1 \
    LANG=C \
    dev/release/verify-release-candidate.sh 12 4

  TEST_DEFAULT=0 \
    TEST_JARS=1 \
    LANG=C \
    dev/release/verify-release-candidate.sh 12 4

  TEST_DEFAULT=0 \
    TEST_WHEELS=1 \
    TEST_PYTHON_VERSIONS=3.11 \
    LANG=C \
    TZ=UTC \
    dev/release/verify-release-candidate.sh 12 4

  TEST_DEFAULT=0 \
    TEST_YUM=1 \
    LANG=C \
    dev/release/verify-release-candidate.sh 12 4

with:

  * g++ (Debian 13.2.0-23) 13.2.0
  * go version go1.22.2 linux/amd64
  * openjdk version "17.0.11" 2024-04-16
  * Python 3.11.9
  * ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux-gnu]
  * R version 4.3.3 (2024-02-29) -- "Angel Food Cake"
  * Apache Arrow 17.0.0-SNAPSHOT

Note:

I needed to install arrow-glib-devel explicitly to verify
Yum repository:

----
diff --git a/dev/release/verify-yum.sh b/dev/release/verify-yum.sh
index f7f023611..ff30176f1 100755
--- a/dev/release/verify-yum.sh
+++ b/dev/release/verify-yum.sh
@@ -170,6 +170,7 @@ echo "::endgroup::"
 
 echo "::group::Test ADBC Arrow GLib"
 
+${install_command} --enablerepo=epel arrow-glib-devel
 ${install_command} --enablerepo=epel adbc-arrow-glib-devel-${package_version}
 ${install_command} --enablerepo=epel adbc-arrow-glib-doc-${package_version}
 
----

adbc-arrow-glib-devel depends on "pkgconfig(arrow-glib)" and
libarrow-glib-devel provided by EPEL also provides it:

$ sudo dnf repoquery --deplist adbc-arrow-glib-devel-12
Last metadata expiration check: 2:01:21 ago on Mon May 20 21:17:44 2024.
package: adbc-arrow-glib-devel-12-1.el9.x86_64
...
  dependency: pkgconfig(arrow-glib)
   provider: arrow-glib-devel-16.1.0-1.el9.x86_64
   provider: libarrow-glib-devel-9.0.0-11.el9.x86_64
...


If I don't install arrow-glib-devel explicitly,
libarrow-glib-devel may be installed. We may need to add
"Conflicts: libarrow-glib-devel" to Apache Arrow's
arrow-glib-devel to resolve this case automatically. Anyway,
this is not a ADBC problem. So it's not a blocker.



Thanks,
-- 
kou


In <fcca9cdc-9c13-477b-9941-7594bffec...@app.fastmail.com>
  "[VOTE] Release Apache Arrow ADBC 12 - RC4" on Wed, 15 May 2024 14:00:33 
+0900,
  "David Li" <lidav...@apache.org> wrote:

> Hello,
> 
> I would like to propose the following release candidate (RC4) of Apache Arrow 
> ADBC version 12. This is a release consisting of 56 resolved GitHub issues 
> [1].
> 
> Please note that the versioning scheme has changed.  This is the 12th release 
> of ADBC, and so is called version "12".  The subcomponents, however, are 
> versioned independently:
> 
> - C/C++/GLib/Go/Python/Ruby: 1.0.0
> - C#: 0.12.0
> - Java: 0.12.0
> - R: 0.12.0
> - Rust: 0.12.0
> 
> These are the versions you will see in the source and in actual packages.  
> The next release will be "13", and the subcomponents will increment their 
> versions independently (to either 1.1.0, 0.13.0, or 1.0.0).  At this point, 
> there is no plan to release subcomponents independently from the project as a 
> whole. 
> 
> Please note that there is a known issue when using the Flight SQL and 
> Snowflake drivers at the same time on x86_64 macOS [12].
> 
> This release candidate is based on commit: 
> 50cb9de621c4d72f4aefd18237cb4b73b82f4a0e [2]
> 
> The source release rc4 is hosted at [3].
> The binary artifacts are hosted at [4][5][6][7][8].
> The changelog is located at [9].
> 
> Please download, verify checksums and signatures, run the unit tests, and 
> vote on the release. See [10] for how to validate a release candidate.
> 
> See also a verification result on GitHub Actions [11].
> 
> The vote will be open for at least 72 hours.
> 
> [ ] +1 Release this as Apache Arrow ADBC 12
> [ ] +0
> [ ] -1 Do not release this as Apache Arrow ADBC 12 because...
> 
> Note: to verify APT/YUM packages on macOS/AArch64, you must `export 
> DOCKER_DEFAULT_PLATFORM=linux/amd64`. (Or skip this step by `export 
> TEST_APT=0 TEST_YUM=0`.)
> 
> [1]: 
> https://github.com/apache/arrow-adbc/issues?q=is%3Aissue+milestone%3A%22ADBC+Libraries+12%22+is%3Aclosed
> [2]: 
> https://github.com/apache/arrow-adbc/commit/50cb9de621c4d72f4aefd18237cb4b73b82f4a0e
> [3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-adbc-12-rc4/
> [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/
> [5]: https://apache.jfrog.io/artifactory/arrow/debian-rc/
> [6]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
> [7]: 
> https://repository.apache.org/content/repositories/staging/org/apache/arrow/adbc/
> [8]: 
> https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-12-rc4
> [9]: 
> https://github.com/apache/arrow-adbc/blob/apache-arrow-adbc-12-rc4/CHANGELOG.md
> [10]: 
> https://arrow.apache.org/adbc/main/development/releasing.html#how-to-verify-release-candidates
> [11]: https://github.com/apache/arrow-adbc/actions/runs/9089931356
> [12]: https://github.com/apache/arrow-adbc/issues/1841

Reply via email to