+1 (non binding) I checked: - LICENSE is OK but maybe worth to keep only LICENSE.txt at root level and move license.tpl in dev folder (I can propose a PR about that) - NOTICE.txt looks a big short, we should mention Included Software / Used Software. I will do a more detailed pass. Definitely not a release blocker. - Java build is OK - ASF headers are present in source files, but some files don't have it (listed in exclude but weird to me, I will do a pass as well).. NB: dev/run-rat.sh needs some fixes and updates (I did several improvements for RAT 0.16). - Quickly tested on my blog samples (new blog post in preparation following https://nanthrax.blogspot.com/2023/12/exposing-apache-karaf-configurations.html)
Thanks ! Regards JB On Wed, Jan 3, 2024 at 9:54 PM David Li <lidav...@apache.org> wrote: > > Hello, > > I would like to propose the following release candidate (RC0) of Apache Arrow > ADBC version 0.9.0. This is a release consisting of 34 resolved GitHub issues > [1]. > > This release candidate is based on commit: > 37a27717fb94fb84211f1b17486cc8f0be7df59c [2] > > The source release rc0 is hosted at [3]. > The binary artifacts are hosted at [4][5][6][7][8]. > The changelog is located at [9]. > > Please download, verify checksums and signatures, run the unit tests, and > vote on the release. See [10] for how to validate a release candidate. > > See also a verification result on GitHub Actions [11]. > > The vote will be open for at least 72 hours. > > [ ] +1 Release this as Apache Arrow ADBC 0.9.0 > [ ] +0 > [ ] -1 Do not release this as Apache Arrow ADBC 0.9.0 because... > > Note: to verify APT/YUM packages on macOS/AArch64, you must `export > DOCKER_DEFAULT_PLATFORM=linux/amd64`. (Or skip this step by `export > TEST_APT=0 TEST_YUM=0`.) > > [1]: > https://github.com/apache/arrow-adbc/issues?q=is%3Aissue+milestone%3A%22ADBC+Libraries+0.9.0%22+is%3Aclosed > [2]: > https://github.com/apache/arrow-adbc/commit/37a27717fb94fb84211f1b17486cc8f0be7df59c > [3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-adbc-0.9.0-rc0/ > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/ > [5]: https://apache.jfrog.io/artifactory/arrow/debian-rc/ > [6]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/ > [7]: > https://repository.apache.org/content/repositories/staging/org/apache/arrow/adbc/ > [8]: > https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.9.0-rc0 > [9]: > https://github.com/apache/arrow-adbc/blob/apache-arrow-adbc-0.9.0-rc0/CHANGELOG.md > [10]: > https://arrow.apache.org/adbc/main/development/releasing.html#how-to-verify-release-candidates > [11]: https://github.com/apache/arrow-adbc/actions/runs/7401997231
