On Tue, Jan 2, 2024 at 5:51 PM Andy Grove <andygrov...@gmail.com> wrote:
> The vote passes with three binding +1 votes. Thanks, everyone. > > Source release: > https://dist.apache.org/repos/dist/release/arrow/arrow-datafusion-python-34.0.0/ > PyPi: https://test.pypi.org/project/datafusion/ > > On Tue, Jan 2, 2024 at 5:39 PM Andy Grove <andygrov...@gmail.com> wrote: > >> Hi Andrew, >> >> It looks like the issue is that numpy 1.21.3 requires a different Python >> version: >> >> 1.21.3 Requires-Python>=3.7,<3.11 >> >> I am guessing that you have a Python version that is not within that >> range? >> >> I agree that this should not be a blocker. >> >> Thanks, >> >> Andy. >> >> >> >> On Fri, Dec 29, 2023 at 4:18 AM Andrew Lamb <al...@influxdata.com> wrote: >> >>> I had some trouble running the verification script -- got an error that >>> a >>> specific version of numpy was not available. I am running on an Apple M3 >>> Max. >>> >>> ERROR: No matching distribution found for numpy==1.21.3 >>> >>> However that version does appear to be available: >>> https://pypi.org/project/numpy/1.21.3/ >>> >>> I was able to verify the release on a Ubuntu 22.04 / x86_64 machine so I >>> don't think this is a release blocker >>> >>> Andrew >>> >>> >>> Here are more details: >>> >>> $ ./dev/release/verify-release-candidate.sh 34.0.0 1 >>> + set -o pipefail >>> +++ dirname ./dev/release/verify-release-candidate.sh >>> ++ cd ./dev/release >>> ++ pwd >>> ... >>> Successfully installed pip-23.3.2 >>> + python3 -m pip install -r requirements-310.txt >>> Collecting attrs==21.2.0 (from -r requirements-310.txt (line 7)) >>> Using cached attrs-21.2.0-py2.py3-none-any.whl (53 kB) >>> Collecting black==21.9b0 (from -r requirements-310.txt (line 11)) >>> Using cached black-21.9b0-py3-none-any.whl (148 kB) >>> Collecting click==8.0.3 (from -r requirements-310.txt (line 15)) >>> Using cached click-8.0.3-py3-none-any.whl (97 kB) >>> Collecting flake8==4.0.1 (from -r requirements-310.txt (line 19)) >>> Using cached flake8-4.0.1-py2.py3-none-any.whl (64 kB) >>> Collecting iniconfig==1.1.1 (from -r requirements-310.txt (line 23)) >>> Using cached iniconfig-1.1.1-py2.py3-none-any.whl (5.0 kB) >>> Collecting isort==5.9.3 (from -r requirements-310.txt (line 27)) >>> Using cached isort-5.9.3-py3-none-any.whl (106 kB) >>> Collecting maturin==0.15.1 (from -r requirements-310.txt (line 31)) >>> Using cached >>> >>> maturin-0.15.1-py3-none-macosx_10_9_x86_64.macosx_11_0_arm64.macosx_10_9_universal2.whl >>> (14.5 MB) >>> Collecting mccabe==0.6.1 (from -r requirements-310.txt (line 46)) >>> Using cached mccabe-0.6.1-py2.py3-none-any.whl (8.6 kB) >>> Collecting mypy==0.910 (from -r requirements-310.txt (line 50)) >>> Using cached mypy-0.910-py3-none-any.whl (2.1 MB) >>> Collecting mypy-extensions==0.4.3 (from -r requirements-310.txt (line >>> 75)) >>> Using cached mypy_extensions-0.4.3-py2.py3-none-any.whl (4.5 kB) >>> ERROR: Ignored the following versions that require a different python >>> version: 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >>> >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >>> >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11 >>> ERROR: Could not find a version that satisfies the requirement >>> numpy==1.21.3 (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, >>> 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, >>> 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, >>> 1.11.3, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 1.13.3, 1.14.0, 1.14.1, 1.14.2, >>> 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, >>> 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0, 1.17.1, >>> 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, >>> 1.18.5, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5, 1.20.0, 1.20.1, >>> 1.20.2, 1.20.3, 1.21.0, 1.21.1, 1.22.0, 1.22.1, 1.22.2, 1.22.3, 1.22.4, >>> 1.23.0rc1, 1.23.0rc2, 1.23.0rc3, 1.23.0, 1.23.1, 1.23.2, 1.23.3, 1.23.4, >>> 1.23.5, 1.24.0rc1, 1.24.0rc2, 1.24.0, 1.24.1, 1.24.2, 1.24.3, 1.24.4, >>> 1.25.0rc1, 1.25.0, 1.25.1, 1.25.2, 1.26.0b1, 1.26.0rc1, 1.26.0, 1.26.1, >>> 1.26.2) >>> ERROR: No matching distribution found for numpy==1.21.3 >>> + cleanup >>> + '[' no = yes ']' >>> + echo 'Failed to verify release candidate. See >>> >>> /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/arrow-34.0.0.XXXXX.Oo74Ac7ank >>> for details.' >>> Failed to verify release candidate. See >>> >>> /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/arrow-34.0.0.XXXXX.Oo74Ac7ank >>> for details. >>> (venv) andrewlamb@Andrews-MacBook-Pro >>> :~/Downloads/apache-arrow-datafusion-python-34.0.0$ >>> >>> >>> On Thu, Dec 28, 2023 at 9:18 PM vin jake <jakevin...@gmail.com> wrote: >>> >>> > +1 (binding) Verified on my M1 Mac. >>> > >>> > Thanks Andy! >>> > >>> > On Fri, Dec 29, 2023 at 5:42 AM Andy Grove <andygrov...@gmail.com> >>> wrote: >>> > >>> > > Hi, >>> > > >>> > > I would like to propose a release of Apache Arrow DataFusion Python >>> > > Bindings, >>> > > version 34.0.0. >>> > > >>> > > This release candidate is based on commit: >>> > > b22f82f3055941dc3599c9a18458a2de163ff4c0 [1] >>> > > The proposed release tarball and signatures are hosted at [2]. >>> > > The changelog is located at [3]. >>> > > The Python wheels are located at [4]. >>> > > >>> > > Please download, verify checksums and signatures, run the unit >>> tests, and >>> > > vote >>> > > on the release. The vote will be open for at least 72 hours. >>> > > >>> > > Only votes from PMC members are binding, but all members of the >>> community >>> > > are >>> > > encouraged to test the release and vote with "(non-binding)". >>> > > >>> > > The standard verification procedure is documented at >>> > > >>> > > >>> > >>> https://github.com/apache/arrow-datafusion-python/blob/main/dev/release/README.md#verifying-release-candidates >>> > > . >>> > > >>> > > [ ] +1 Release this as Apache Arrow DataFusion Python 34.0.0 >>> > > [ ] +0 >>> > > [ ] -1 Do not release this as Apache Arrow DataFusion Python 34.0.0 >>> > > because... >>> > > >>> > > Here is my vote: >>> > > >>> > > +1 >>> > > >>> > > [1]: >>> > > >>> > > >>> > >>> https://github.com/apache/arrow-datafusion-python/tree/b22f82f3055941dc3599c9a18458a2de163ff4c0 >>> > > [2]: >>> > > >>> > > >>> > >>> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-python-34.0.0-rc1 >>> > > [3]: >>> > > >>> > > >>> > >>> https://github.com/apache/arrow-datafusion-python/blob/b22f82f3055941dc3599c9a18458a2de163ff4c0/CHANGELOG.md >>> > > [4]: https://test.pypi.org/project/datafusion/34.0.0/ >>> > > >>> > >>> >>
