+1 I ran TEST_DEFAULT=0 TEST_CPP=1 dev/release/verify-release-candidate.sh 14.0.2 3 on MacOS M1. I do get one failing test (gandiva-internals-test) but this has failed for me for the last three versions.
Note that the R bindings will have to patch the static libraries we host for convenience installation of the R package with https://github.com/apache/arrow/pull/39186 because of the warning flags that are set on the CRAN builder. I consider R a "packaging" step, and because we (and other downstream maintainers) often apply tweaks between versions as post-release steps, I think this is fine. However, I did want to highlight that here in case anybody feels strongly that adding two static_casts<>s into the R package warrants another release candidate. On Fri, Dec 15, 2023 at 1:36 AM wish maple <maplewish...@gmail.com> wrote: > > +1 (binding) > > Verified C++ and Python in my M1 MacOS > > Best, > Xuwei Fu > > Jean-Baptiste Onofré <j...@nanthrax.net> 于2023年12月15日周五 00:19写道： > > > +1 (non binding) > > > > I checked: > > - hash and signature are OK > > - build is OK as soon as submodule are added (see the discussion on > > another thread) > > - LICENSE and NOTICE look good (maybe worth updating copyright date) > > - I checked RAT, and some files in the exclude should actually contain > > ASF header. I will propose a PR to improve this, not a blocker for > > release though. > > > > Thanks ! > > Regards > > JB > > > > On Wed, Dec 13, 2023 at 10:32 PM Raúl Cumplido <rau...@apache.org> wrote: > > > > > > Hi, > > > > > > I would like to propose the following release candidate (RC3) of Apache > > > Arrow version 14.0.2. This is a release consisting of 30 > > > resolved GitHub issues[1]. > > > > > > This release candidate is based on commit: > > > 740889f413af9b1ae1d81eb1e5a4a9fb4ce9cf97 [2] > > > > > > The source release rc3 is hosted at [3]. > > > The binary artifacts are hosted at [4][5][6][7][8][9][10][11]. > > > The changelog is located at [12]. > > > > > > Please download, verify checksums and signatures, run the unit tests, > > > and vote on the release. See [13] for how to validate a release > > candidate. > > > > > > See also a verification result on GitHub pull request [14]. > > > > > > The vote will be open for at least 72 hours. > > > > > > [ ] +1 Release this as Apache Arrow 14.0.2 > > > [ ] +0 > > > [ ] -1 Do not release this as Apache Arrow 14.0.2 because... > > > > > > [1]: > > https://github.com/apache/arrow/issues?q=is%3Aissue+milestone%3A14.0.2+is%3Aclosed > > > [2]: > > https://github.com/apache/arrow/tree/740889f413af9b1ae1d81eb1e5a4a9fb4ce9cf97 > > > [3]: > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-14.0.2-rc3 > > > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/ > > > [5]: https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/ > > > [6]: https://apache.jfrog.io/artifactory/arrow/centos-rc/ > > > [7]: https://apache.jfrog.io/artifactory/arrow/debian-rc/ > > > [8]: https://apache.jfrog.io/artifactory/arrow/java-rc/14.0.2-rc3 > > > [9]: https://apache.jfrog.io/artifactory/arrow/nuget-rc/14.0.2-rc3 > > > [10]: https://apache.jfrog.io/artifactory/arrow/python-rc/14.0.2-rc3 > > > [11]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/ > > > [12]: > > https://github.com/apache/arrow/blob/740889f413af9b1ae1d81eb1e5a4a9fb4ce9cf97/CHANGELOG.md > > > [13]: > > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > > [14]: https://github.com/apache/arrow/pull/39193 > >
