+1 (non-binding) Verified on MacOS (M1) using conda.
A couple of nuances: * Had to uninstall gnupg in conda and used brew's gnupg instead (same issue Will found). * I initially encountered some intermittent CMake build timeouts with gtest, but haven't been able to reproduce. On Tue, Jun 20, 2023 at 9:55 AM Antoine Pitrou <anto...@python.org> wrote: > > I don't have much time to investigate and I don't think it's a blocker > either way. Perhaps there's room for improvement on the Arrow C++ side > as well... > > > Le 20/06/2023 à 15:40, Dewey Dunnington a écrit : > > Thanks for verifying! > > > > I don't *think* there is anything non-standard about the > > `find_package(Arrow)` / `target_link_libraries(..., arrow_shared)` > > sequence used to link the tests (although clearly they aren't working > > as intended!). You can pass extra arguments to CMake to help it find > > the right Arrow using export NANOARROW_CMAKE_OPTIONS="-DArrow_DIR=..." > > but here it sounds like it's finding the .so but failing to link the > > dependencies. There are also instructions on creating a conda > > environment with all required dependencies at [1]. > > > > [1] > https://github.com/apache/arrow-nanoarrow/blob/main/dev/release/README.md#conda-linux-and-macos > > > > On Tue, Jun 20, 2023 at 9:32 AM Antoine Pitrou <anto...@python.org> > wrote: > >> > >> > >> Ok, now running from the right repo :-), I get linker errors against > >> Arrow C++ dependencies: > >> > >> [ 44%] Linking CXX executable utils_test > >> > /home/antoine/mambaforge/envs/pyarrow/bin/../lib/gcc/x86_64-conda-linux-gnu/12.2.0/../../../../x86_64-conda-linux-gnu/bin/ld: > >> warning: libcrypto.so.3, needed by > >> /home/antoine/mambaforge/envs/pyarrow/lib/libarrow.so.1300.0.0, not > >> found (try using -rpath or -rpath-link) > >> > >> (etc.) > >> > >> https://gist.github.com/pitrou/3e6e9621e3b6cc2aff932eafdafef82b > >> > >> Note that Arrow C++ is compiled by myself inside a conda environment > >> (which is activated when running the verification script). > >> > >> Regards > >> > >> Antoine. > >> > >> > >> > >> Le 20/06/2023 à 12:38, Raúl Cumplido a écrit : > >>> +1 (non-binding) > >>> > >>> I've run: > >>> ./verify-release-candidate.sh 0.2.0 1 > >>> > >>> on Ubuntu 22.04 with conda: > >>> * arrow-cpp 12.0.0 > >>> * gcc (conda-forge gcc 11.4.0-0) 11.4.0 > >>> * r-base 4.2.3 > >>> > >>> Thanks, > >>> Raúl > >>> > >>> El mar, 20 jun 2023 a las 1:55, Sutou Kouhei (<k...@clear-code.com>) > escribió: > >>>> > >>>> +1 > >>>> > >>>> I ran the following command line on Debian GNU/Linux sid: > >>>> > >>>> CMAKE_PREFIX_PATH=/tmp/local \ > >>>> dev/release/verify-release-candidate.sh 0.2.0 1 > >>>> > >>>> with: > >>>> > >>>> * Apache Arrow C++ main > >>>> * gcc (Debian 12.2.0-14) 12.2.0 > >>>> * R version 4.3.0 (2023-04-21) -- "Already Tomorrow" > >>>> > >>>> > >>>> Thanks, > >>>> -- > >>>> kou > >>>> > >>>> In <CAFb7qSfRiAc9cGztr=JxuB9kHTue= > oy-8keyn0at47jpmaw...@mail.gmail.com> > >>>> "[VOTE] Release Apache Arrow nanoarrow 0.2.0 - RC1" on Mon, 19 > Jun 2023 15:58:45 -0300, > >>>> Dewey Dunnington <de...@voltrondata.com.INVALID> wrote: > >>>> > >>>>> Hello, > >>>>> > >>>>> I would like to propose the following release candidate (RC1) of > >>>>> Apache Arrow nanoarrow version 0.2.0. This release consists of 17 > >>>>> resolved GitHub issues [1]. > >>>>> > >>>>> This release candidate is based on commit: > >>>>> f71063605e288d9a8dd73cfdd9578773519b6743 [2] > >>>>> > >>>>> The source release rc1 is hosted at [3]. > >>>>> The changelog is located at [4]. > >>>>> The draft release post is located at [5]. > >>>>> > >>>>> Please download, verify checksums and signatures, run the unit tests, > >>>>> and vote on the release. See [6] for how to validate a release > >>>>> candidate. > >>>>> > >>>>> The vote will be open for at least 72 hours. > >>>>> > >>>>> [ ] +1 Release this as Apache Arrow nanoarrow 0.2.0 > >>>>> [ ] +0 > >>>>> [ ] -1 Do not release this as Apache Arrow nanoarrow 0.2.0 because... > >>>>> > >>>>> [0] https://github.com/apache/arrow-nanoarrow > >>>>> [1] https://github.com/apache/arrow-nanoarrow/milestone/2?closed=1 > >>>>> [2] > https://github.com/apache/arrow-nanoarrow/tree/apache-arrow-nanoarrow-0.2.0-rc1 > >>>>> [3] > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-nanoarrow-0.2.0-rc1/ > >>>>> [4] > https://github.com/apache/arrow-nanoarrow/blob/apache-arrow-nanoarrow-0.2.0-rc1/CHANGELOG.md > >>>>> [5] https://github.com/apache/arrow-site/pull/364 > >>>>> [6] > https://github.com/apache/arrow-nanoarrow/blob/main/dev/release/README.md >
