Well, precompiled headers do not necessarily work well with ccache: https://github.com/apache/arrow/issues/35641#issuecomment-1551775293 But agreed with the rest. Le 16/06/2023 à 02:15, Sutou Kouhei a écrit :
Hi, Ah, sorry. I should have written it in the original e-mail. If we can require CMake 3.16+: * We can always use the precompiled headers feature that reduces build time: https://github.com/apache/arrow/pull/35921/files#diff-1bba462ab050e89360fd88110a689e85ee037749cea091a1848ab574381d3795L236 * We can remove our bundled FindPythonLibsNew.cmake and FindNumPy.cmake: https://github.com/apache/arrow/pull/35921/files#diff-96c2eed475b13f84b0e0b4ce871fcf225d3d75d8c1ebd9d2b2d7183fa2a603f5L44 Users don't need to specify both of -DPYTHON_EXECUTABLE and -DPython3_EXECUTABLE for old/new CMake: https://github.com/apache/arrow/pull/35921/files#diff-91a09bc7b04c0122375fb44ec755065daccba993f95f96a26df129c4df9bb438L377 * We can remove a Boost::headers related shim code: https://github.com/apache/arrow/pull/35921/files#diff-5cdc95f4e1b618f2f3ef10d370ce05a1ac05d9d401aecff3ccbb3d76bd366b6aL1203 * Jacob wants to use FetchContent related features: https://github.com/apache/arrow/pull/35921#issuecomment-1585428356 Thanks,
