+1! On Windows/Git Bash I ran: PATH="$PATH:/c/PROGRA~1/R/R-43~1.0/bin" TEST_DEFAULT=0 TEST_R=1 dev/release/verify-release-candidate.sh 0.4.0 0
On Ubuntu 22.04 I ran: TEST_APT=0 TEST_YUM=0 USE_CONDA=1 dev/release/verify-release-candidate.sh 0.4.0 0 I wasn't able to verify on MacOS/aarch64 because of the Snowflake driver issue (but have verified Matt's fix to be included in the next release locally). I also wasn't able to get the PowerShell verification script working but will pursue that and/or add some instructions as I have time before the next release. On Wed, May 10, 2023 at 8:22 PM David Li <lidav...@apache.org> wrote: > > My vote: +1 > > I verified on Ubuntu 22.04/Conda/AMD64 and macOS 13/Conda/AArch64 (sources > only there). I had to disable all the Snowflake driver builds for macOS as > those aren't working on non-AMD64 platforms (that was fixed earlier today by > Matt for the next release). > > Re: missing packages, I agree we should install them all via Conda. > > How long do we expect to need the Arch workaround? We don't currently test > with Arch in the first place so that might bitrot quickly (especially as it's > Arch). > > On Wed, May 10, 2023, at 18:12, Will Jones wrote: > > +1 (binding) > > > > Verified on Ubuntu 22 with USE_CONDA=1 > > dev/release/verify-release-candidate.sh 0.4.0 0 > > > > On Wed, May 10, 2023 at 2:27 PM Matt Topol <zotthewiz...@gmail.com> wrote: > > > >> Using a manjaro linux image (in honor of the issues we found for Arrow v12 > >> rc) I ran: > >> USE_CONDA=1 ./dev/release/verify-release-candidate.sh 0.4.0 0 > >> > >> My first attempt failed because the default base image doesn't have make > >> and such installed. should we install that via conda too since we install > >> the compilers and toolchains through conda when USE_CONDA=1? > >> > >> After installing `base-devel` package which gives make/autoconf/etc.... > >> everything ran properly and worked just fine for verifying the candidate. > >> > >> So I'm +1 on the release (I'm fine with requiring that base-devel package > >> installed) but I wanted to bring up/suggest the idea of installing make > >> through conda also. That said, it still has the same libcrypt.so.1 issue > >> that we saw with the Arrow v12 release, maybe we should add a note in the > >> documentation that the `libxcrypt-compat` package is needed to build on any > >> `pacman` / ArchLinux based systems? > >> > >> On Wed, May 10, 2023 at 7:03 AM Raúl Cumplido <raulcumpl...@gmail.com> > >> wrote: > >> > >> > +1 > >> > > >> > I ran the following on Ubuntu 22.04: > >> > USE_CONDA=1 ./dev/release/verify-release-candidate.sh 0.4.0 0 > >> > > >> > El mié, 10 may 2023 a las 9:59, Sutou Kouhei (<k...@clear-code.com>) > >> > escribió: > >> > > > >> > > +1 > >> > > > >> > > I ran the following on Debian GNU/Linux sid: > >> > > > >> > > JAVA_HOME=/usr/lib/jvm/default-java \ > >> > > TEST_PYTHON_VERSIONS=3.11 \ > >> > > dev/release/verify-release-candidate.sh 0.4.0 0 > >> > > > >> > > with: > >> > > > >> > > * Python 3.11.2 > >> > > * g++ (Debian 12.2.0-14) 12.2.0 > >> > > * go version go1.19.8 linux/amd64 > >> > > * openjdk version "17.0.6" 2023-01-17 > >> > > * ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux-gnu] > >> > > * R version 4.3.0 (2023-04-21) -- "Already Tomorrow" > >> > > > >> > > Thanks, > >> > > -- > >> > > kou > >> > > > >> > > > >> > > In <831038c5-0ab3-4dae-80e3-07c882dce...@app.fastmail.com> > >> > > "[VOTE] Release Apache Arrow ADBC 0.4.0 - RC0" on Tue, 09 May 2023 > >> > 21:46:48 -0400, > >> > > "David Li" <lidav...@apache.org> wrote: > >> > > > >> > > > Hello, > >> > > > > >> > > > I would like to propose the following release candidate (RC0) of > >> > Apache Arrow ADBC version 0.4.0. This is a release consisting of 47 > >> > resolved GitHub issues [1]. > >> > > > > >> > > > This release candidate is based on commit: > >> > cdb8fba8faaaa6ca26647863224fb7fd9fc74097 [2] > >> > > > > >> > > > The source release rc0 is hosted at [3]. > >> > > > The binary artifacts are hosted at [4][5][6][7][8]. > >> > > > The changelog is located at [9]. > >> > > > > >> > > > Please download, verify checksums and signatures, run the unit tests, > >> > and vote on the release. See [10] for how to validate a release > >> candidate. > >> > > > > >> > > > See also a verification result on GitHub Actions [11]. > >> > > > > >> > > > The vote will be open for at least 72 hours. > >> > > > > >> > > > [ ] +1 Release this as Apache Arrow ADBC 0.4.0 > >> > > > [ ] +0 > >> > > > [ ] -1 Do not release this as Apache Arrow ADBC 0.4.0 because... > >> > > > > >> > > > Note: to verify APT/YUM packages on macOS/AArch64, you must `export > >> > DOCKER_DEFAULT_ARCHITECTURE=linux/amd64`. (Or skip this step by `export > >> > TEST_APT=0 TEST_YUM=0`.) > >> > > > > >> > > > [1]: > >> > > >> https://github.com/apache/arrow-adbc/issues?q=is%3Aissue+milestone%3A%22ADBC+Libraries+0.4.0%22+is%3Aclosed > >> > > > [2]: > >> > > >> https://github.com/apache/arrow-adbc/commit/cdb8fba8faaaa6ca26647863224fb7fd9fc74097 > >> > > > [3]: > >> > > >> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-adbc-0.4.0-rc0/ > >> > > > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/ > >> > > > [5]: https://apache.jfrog.io/artifactory/arrow/debian-rc/ > >> > > > [6]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/ > >> > > > [7]: > >> > > >> https://repository.apache.org/content/repositories/staging/org/apache/arrow/adbc/ > >> > > > [8]: > >> > > >> https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.4.0-rc0 > >> > > > [9]: > >> > > >> https://github.com/apache/arrow-adbc/blob/apache-arrow-adbc-0.4.0-rc0/CHANGELOG.md > >> > > > [10]: > >> > > >> https://arrow.apache.org/adbc/main/development/releasing.html#how-to-verify-release-candidates > >> > > > [11]: https://github.com/apache/arrow-adbc/actions/runs/4931782221 > >> > > >>
