Thanks Weston. I don’t own the code that broke so it’s possible that it was ignored.
Thanks for the links! On Fri, Sep 9, 2022 at 8:44 PM Weston Pace <weston.p...@gmail.com> wrote: > Breaking changes should be documented in the release notes which are > announced on the Arrow blog[1][2]. In addition, in pyarrow, changes > to non-experimental APIs (and often also those made to experimental > APIs) should go through a deprecation cycle where a warning is emitted > for at least one release. > > It appears the `chunksize` vs. `max_chunksize` change should have > emitted a warning for the last 3 years[3]. Is it possible that you > have warnings disabled? > > Also, it looks like there should have been a deprecation warning for > read_schema as well[4]. > > [1] https://arrow.apache.org/blog/2022/05/15/8.0.0-release/ > [2] https://arrow.apache.org/blog/2022/08/16/9.0.0-release/ > [3] > https://github.com/apache/arrow/blame/3eb5673597bf67246271b6c9a98e6f812d4e01a7/python/pyarrow/table.pxi#L1991 > [4] > https://github.com/apache/arrow/blob/apache-arrow-7.0.0/python/pyarrow/__init__.py#L368 > > On Fri, Sep 9, 2022 at 10:15 AM Li Jin <ice.xell...@gmail.com> wrote: > > > > After digging the code a bit, it looks like: > > (1) pyarrow.read_schema should be changed to pyarrow.ipc.read_schema > > (2) chunksize should be changed to max_chunksize (it was passed in as a > > generic kwargs before and I am guessing it was a wrong in the first > place) > > > > These seem to be easy enough to fix but just wondering in general where > do > > I look first if I hit this sort of issue in the future. > > > > On Fri, Sep 9, 2022 at 12:20 PM Li Jin <ice.xell...@gmail.com> wrote: > > > > > Hi, > > > > > > I am trying to update Pyarrow from 7.0 to 9.0 and hit a couple of > issues > > > that I believe are because of some API changes. In particular, two > issues I > > > saw seems to be > > > > > > (1) pyarrow.read_schema is removed > > > (2) pa.Table.to_batches no longer takes a keyword argument (chunksize) > > > > > > What's the best way to find API change notes and fix it? > > > > > > Thanks, > > > Li > > > >
