Thanks Antoine! I've updated the PR (except for the comment about timeout units, since SqlInfo values can't be doubles/floats unless we change the schema there)
On Tue, Sep 6, 2022, at 09:24, Antoine Pitrou wrote: > Hi, > > Sorry for the delay. I took the time to read the protobuf definitions > again and posted a few (relatively minor) comments in the PR. > > On the principle the spec looks sound so I'm giving this a +1 (binding). > > Regards > > Antoine. > > > Le 01/09/2022 à 01:51, David Li a écrit : >> Hello, >> >> I am proposing to extend the Flight SQL specification with the following >> features: >> >> - Support for queries using Substrait [1] >> - Explicit transaction RPCs >> - Explicit cancellation of distributed queries >> >> The proposal was discussed previously in [2]. The new Protobuf definitions, >> an implementation for C++ and Java, and integration tests, are available at >> [3] with some further discussion. >> >> The vote will be open for at least 72 hours. >> >> [ ] +1 : Accept the proposal >> [ ] 0 : No opinion >> [ ] -1 : Do not accept this proposal because... >> >> [1]: https://substrait.io/ >> [2]: https://lists.apache.org/thread/l6j0nc43y7czs2m4kpzrckmrtgr9qs9z >> [3]: https://github.com/apache/arrow/pull/13492
