I'm sure that I didn't hit this error when I verified the release. However, I can reproduce the error now.
It seems due to serde_json 1.0.84+. When I specify versions like 1.0.83 or 1.0.82, it can pass. https://github.com/serde-rs/json/releases/tag/v1.0.84 makes some changes to Debug of serde_json::Value. As the test failure is the difference of error message, I think it won't affect the functionalities. Submitted a PR to fix the test: https://github.com/apache/arrow-rs/pull/2546 Not sure if we should cut RC3 for that. On Sun, Aug 21, 2022 at 3:11 PM Andy Grove <andygrov...@gmail.com> wrote: > > I tried verifying on mac and ubuntu and both failed with: > > failures: > > ---- json::reader::tests::test_row_type_validation stdout ---- > thread 'json::reader::tests::test_row_type_validation' panicked at > 'assertion failed: `(left == right)` > left: `"Json error: Expected JSON record to be an object, found Array > [Number(1), String(\"hello\")]"`, > right: `"Json error: Expected JSON record to be an object, found > Array([Number(1), String(\"hello\")])"`', src/json/reader.rs:2624:9 > > > failures: > json::reader::tests::test_row_type_validation > > > > On Thu, Aug 18, 2022 at 3:23 PM Andrew Lamb <al...@influxdata.com> wrote: > > > Hi, > > > > I would like to propose a release of Apache Arrow Rust Implementation, > > version 21.0.0. > > > > This release candidate is based on commit: > > 68934f0fa5da62ae9fcbb753d1dfd8f672a4eb1e [1] > > > > The proposed release tarball and signatures are hosted at [2]. > > > > The changelog is located at [3]. > > > > Please download, verify checksums and signatures, run the unit tests, > > and vote on the release. There is a script [4] that automates some of > > the verification. > > > > Please note > > 1. The verification script has changed since last release [5][6] > > 2. This is RC 2 (the first release candidate has problems in the > > verification script -- see [6]) > > > > The vote will be open for at least 72 hours. > > > > [ ] +1 Release this as Apache Arrow Rust > > [ ] +0 > > [ ] -1 Do not release this as Apache Arrow Rust because... > > > > [1]: > > > > https://github.com/apache/arrow-rs/tree/68934f0fa5da62ae9fcbb753d1dfd8f672a4eb1e > > [2]: > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-rs-21.0.0-rc2 > > [3]: > > > > https://github.com/apache/arrow-rs/blob/68934f0fa5da62ae9fcbb753d1dfd8f672a4eb1e/CHANGELOG.md > > [4]: > > > > https://github.com/apache/arrow-rs/blob/master/dev/release/verify-release-candidate.sh > > [5]: https://github.com/apache/arrow-rs/pull/2339 > > [6]: https://github.com/apache/arrow-rs/pull/2506 > >