That sounds reasonable to me - I'll put together a PR. Given that the header keys could be anything, I think it makes sense to have the server register those headers it's interested in having exposed.
*Kyle Porter* CEO Bit Quill Technologies Inc. Office: +1.778.331.3355 | Direct: +1.604.441.7318 | ky...@bitquilltech.com https://www.bitquilltech.com This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure, or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. Thank you. > From: David Li <li.david...@gmail.com> > Date: Tue, Nov 3, 2020 at 2:23 PM > Subject: Re: [FlightRPC][Java] Properties and headers > To: <dev@arrow.apache.org> > > > There's already a simple CallHeaders interface: > > https://github.com/apache/arrow/blob/master/java/flight/flight-core/src/main/java/org/apache/arrow/flight/CallHeaders.java > > The client side could accept one via a CallOptions and the server side > could expose them via middleware. > > Then for the 'client properties', helpers could construct the > CallOption on the client side and extract the properties from the call > context on the server side. > > Best, > David > > On 11/3/20, Kyle Porter <ky...@bitquilltech.com> wrote: > > Hi all, > > > > https://issues.apache.org/jira/browse/ARROW-10467 proposed the ability > to > > specify client properties via a CallOption that would be passed for > > consumption to the server, and David Li suggested instead we improve the > > ability to pass headers in general rather than special casing it to > > properties (here: https://github.com/apache/arrow/pull/8572) > > > > Wanted to raise this, as I think you could add a CallOption for headers > > that took the header name and a value that could be serialized, and > either > > have the server register a callback for specific header values via > > middleware or be able to request headers on demand. Thoughts? > > > > I can put together a quick PR to demonstrate the first option if desired. > > > > *Kyle Porter* > > CEO > > Bit Quill Technologies Inc. > > Office: +1.778.331.3355 | Direct: +1.604.441.7318 | > ky...@bitquilltech.com > > https://www.bitquilltech.com > > > > This email message is for the sole use of the intended recipient(s) and > may > > contain confidential and privileged information. Any unauthorized > review, > > use, disclosure, or distribution is prohibited. If you are not the > > intended recipient, please contact the sender by reply email and destroy > > all copies of the original message. Thank you. > > >
