+1 (non-binding) On Tue, Sep 29, 2020 at 6:08 PM Sutou Kouhei <k...@clear-code.com> wrote:
> +1 > > In <CAKa9qDn+SzYzY87=eZDyFDD=zq1ekytnfbz544tnzg9nevc...@mail.gmail.com> > "Re: [VOTE][Format] Allow for 256-bit Decimal's in the Arrow > specification" on Tue, 29 Sep 2020 13:38:04 -0700, > Jacques Nadeau <jacq...@apache.org> wrote: > > > +1 > > > > On Tue, Sep 29, 2020 at 11:19 AM Wes McKinney <wesmck...@gmail.com> > wrote: > > > >> +1 > >> > >> On Tue, Sep 29, 2020 at 4:07 AM Fan Liya <liya.fa...@gmail.com> wrote: > >> > > >> > +1 > >> > > >> > Best, > >> > Liya Fan > >> > > >> > On Tue, Sep 29, 2020 at 4:55 PM Antoine Pitrou <anto...@python.org> > >> wrote: > >> > > >> > > > >> > > +1 (binding) > >> > > > >> > > I didn't look at the implementation. > >> > > > >> > > Regards > >> > > > >> > > Antoine. > >> > > > >> > > > >> > > Le 29/09/2020 à 06:54, Micah Kornfield a écrit : > >> > > > I've opened a PR that updates the specification to allow for > 256-bit > >> > > > Decimal types [1]. It updates both schema.fbs and the C-ABI to > >> document > >> > > > this support. > >> > > > > >> > > > The decimal256 branch [2] contains implementations in Java and C++ > >> and > >> > > > updates to the integration test to demonstrate interoperability. > If > >> this > >> > > > vote passes I will open up a PR to merge the decimal256 branch to > >> master > >> > > > and we can handle any specific concerns for the implementations on > >> that > >> > > > PR. This vote is specifically about approving and merging [1]. > >> > > > > >> > > > The vote will remain open for at least 72 hours. > >> > > > > >> > > > [ ] +1: Accept 256 bit Decimals as part of the specification > >> > > > [ ] +0: > >> > > > [ ] -1: I don't think this is a good idea because ... > >> > > > > >> > > > Thanks, > >> > > > Micah > >> > > > > >> > > > [1] https://github.com/apache/arrow/pull/8293 > >> > > > [2] https://github.com/apache/arrow/tree/decimal256 > >> > > > > >> > > > >> > -- Twitter: https://twitter.com/holdenkarau Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 <https://amzn.to/2MaRAG9> YouTube Live Streams: https://www.youtube.com/user/holdenkarau
