On Fri, Jul 24, 2020 at 2:25 PM Ryan Murray <rym...@dremio.com> wrote: > > Hey Krisztian, > > I agree. I ran it on LLVM/Clang 9 and 10 and it failed both times. Given > that everyone else had it succeed and there are a few tickets open around > LLVM > 8 I suspect it is Clang. I am currently running w/ 8 to see if it > passes. Do we have documents anywhere that list Gandiva's LLVM/Clang > requirements? I don't think so, but at least 10 should work since we extensively test it in our CI setup.
Please try to reproduce it on the master branch and file a jira ticket if the issue persist. > > Best > > Ryan > > On Fri, Jul 24, 2020 at 1:18 PM Krisztián Szűcs <szucs.kriszt...@gmail.com> > wrote: > > > On Tue, Jul 21, 2020 at 3:57 PM Ryan Murray <rym...@dremio.com> wrote: > > > > > > +0 (non-binding) > > > > > > > > > I verified source, release, binaries, integration tests for Python, C++, > > > Java. All went fine except for a failed test in c++ Gandiva: [ FAILED ] > > > TestProjector.TestDateTime > > > > It's hard to evaluate without any context. > > > > I executed specifically this test case locally and it has passed. > > According to the rest of the votes I don't consider it as a blocker. > > > > > > > > > > > Not sure if this is known or expected? > > > > > > > > > On Tue, Jul 21, 2020 at 1:32 PM Andy Grove <andygrov...@gmail.com> > > wrote: > > > > > > > +1 (binding) on testing the Rust implementation only. > > > > > > > > I did notice that the release script is not updating all the versions > > > > correctly and I filed a JIRA [1]. > > > > > > > > This shouldn't prevent the release though since this one version > > number can > > > > be updated manually when we publish the crates. > > > > > > > > [1] https://issues.apache.org/jira/browse/ARROW-9537 > > > > > > > > On Mon, Jul 20, 2020 at 8:08 PM Krisztián Szűcs < > > szucs.kriszt...@gmail.com > > > > > > > > > wrote: > > > > > > > > > Hi, > > > > > > > > > > I would like to propose the following release candidate (RC2) of > > Apache > > > > > Arrow version 1.0.0. This is a release consisting of 838 > > > > > resolved JIRA issues[1]. > > > > > > > > > > This release candidate is based on commit: > > > > > b0d623957db820de4f1ff0a5ebd3e888194a48f0 [2] > > > > > > > > > > The source release rc2 is hosted at [3]. > > > > > The binary artifacts are hosted at [4][5][6][7]. > > > > > The changelog is located at [8]. > > > > > > > > > > Please download, verify checksums and signatures, run the unit tests, > > > > > and vote on the release. See [9] for how to validate a release > > candidate. > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > > > [ ] +1 Release this as Apache Arrow 1.0.0 > > > > > [ ] +0 > > > > > [ ] -1 Do not release this as Apache Arrow 1.0.0 because... > > > > > > > > > > [1]: > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%201.0.0 > > > > > [2]: > > > > > > > > > > > https://github.com/apache/arrow/tree/b0d623957db820de4f1ff0a5ebd3e888194a48f0 > > > > > [3]: > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-1.0.0-rc2 > > > > > [4]: https://bintray.com/apache/arrow/centos-rc/1.0.0-rc2 > > > > > [5]: https://bintray.com/apache/arrow/debian-rc/1.0.0-rc2 > > > > > [6]: https://bintray.com/apache/arrow/python-rc/1.0.0-rc2 > > > > > [7]: https://bintray.com/apache/arrow/ubuntu-rc/1.0.0-rc2 > > > > > [8]: > > > > > > > > > > > https://github.com/apache/arrow/blob/b0d623957db820de4f1ff0a5ebd3e888194a48f0/CHANGELOG.md > > > > > [9]: > > > > > > > > > > > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > > > > > > > > > >
