Right, sorry about that. So the difference it turns out is the UNITY build. The compiler error in ARROW-8510 does not occur for some reason when CMAKE_UNITY_BUILD=ON.
On Sat, Apr 18, 2020 at 3:36 PM Antoine Pitrou <anto...@python.org> wrote: > > > We build with both VS2015 and VS2017 on AppVeyor. > > Regards > > Antoine. > > > Le 18/04/2020 à 22:34, Wes McKinney a écrit : > > The release verification script (which uses the VS 2017 compiler mode) > > fails for me on Windows > > > > https://issues.apache.org/jira/browse/ARROW-8510 > > > > It looks like we are building with VS 2019 in CI. We may want to be > > more conservative and build with VS 2015 or VS 2017 in CI. This is > > peculiar though because the wheels are using VS 2015. So it's possible > > there's a compiler bug with VS 2017 that doesn't present on VS 2015. > > > > I don't think this should block the release however. I'll vote after I > > check some more things > > > > On Sat, Apr 18, 2020 at 3:32 PM Neal Richardson > > <neal.p.richard...@gmail.com> wrote: > >> > >> +1 (binding) > >> > >> I ran verification on Ubuntu, macOS, and Windows using crossbow. Thanks to > >> all who helped debug. A few things are still failing: see > >> https://github.com/apache/arrow/pull/6961#issuecomment-615940240 for > >> details. Since Python folks are unconcerned by the wheel issues I > >> encountered, I won't object. > >> > >> In addition to the usual verifications, I worked with Jeroen to build the R > >> Windows binaries for the 0.17 rc0 and confirmed that the R package passes > >> all checks with them. > >> > >> Neal > >> > >> On Sat, Apr 18, 2020 at 12:13 AM Sutou Kouhei <k...@clear-code.com> wrote: > >> > >>> +1 (binding) > >>> > >>> I ran the followings on Debian GNU/Linux sid: > >>> > >>> * TEST_CSHARP=0 \ > >>> JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 \ > >>> CUDA_TOOLKIT_ROOT=/usr \ > >>> ARROW_CMAKE_OPTIONS=-DgRPC_SOURCE=BUNDLED \ > >>> dev/release/verify-release-candidate.sh source 0.17.0 0 > >>> * dev/release/verify-release-candidate.sh binaries 0.17.0 0 > >>> * dev/release/verify-release-candidate.sh wheels 0.17.0 0 > >>> > >>> with: > >>> > >>> * gcc (Debian 9.3.0-10) 9.3.0 > >>> * openjdk version "1.8.0_252" > >>> * Node.JS v12.1.0 > >>> * nvidia-cuda-dev 10.1.168-8 > >>> > >>> Notes: > >>> > >>> * C# sourcelink is failed as usual. > >>> https://issues.apache.org/jira/browse/ARROW-8505 > >>> > >>> > >>> Thanks, > >>> -- > >>> kou > >>> > >>> In <CAHM19a5t9=xuMHPgp=qDj3F2Bp-30wq=ykocv1cymwkvhuk...@mail.gmail.com> > >>> "[VOTE] Release Apache Arrow 0.17.0 - RC0" on Fri, 17 Apr 2020 02:26:34 > >>> +0200, > >>> Krisztián Szűcs <szucs.kriszt...@gmail.com> wrote: > >>> > >>>> Hi, > >>>> > >>>> I would like to propose the following release candidate (RC0) of Apache > >>>> Arrow version 0.17.0. This is a release consisting of 582 > >>>> resolved JIRA issues[1]. > >>>> > >>>> This release candidate is based on commit: > >>>> 3cbcb7b62c2f2d02851bff837758637eb592a64b [2] > >>>> > >>>> The source release rc0 is hosted at [3]. > >>>> The binary artifacts are hosted at [4][5][6][7]. > >>>> The changelog is located at [8]. > >>>> > >>>> Please download, verify checksums and signatures, run the unit tests, > >>>> and vote on the release. See [9] for how to validate a release candidate. > >>>> > >>>> The vote will be open for at least 72 hours. > >>>> > >>>> [ ] +1 Release this as Apache Arrow 0.17.0 > >>>> [ ] +0 > >>>> [ ] -1 Do not release this as Apache Arrow 0.17.0 because... > >>>> > >>>> [1]: > >>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%200.17.0 > >>>> [2]: > >>> https://github.com/apache/arrow/tree/3cbcb7b62c2f2d02851bff837758637eb592a64b > >>>> [3]: > >>> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.17.0-rc0 > >>>> [4]: https://bintray.com/apache/arrow/centos-rc/0.17.0-rc0 > >>>> [5]: https://bintray.com/apache/arrow/debian-rc/0.17.0-rc0 > >>>> [6]: https://bintray.com/apache/arrow/python-rc/0.17.0-rc0 > >>>> [7]: https://bintray.com/apache/arrow/ubuntu-rc/0.17.0-rc0 > >>>> [8]: > >>> https://github.com/apache/arrow/blob/3cbcb7b62c2f2d02851bff837758637eb592a64b/CHANGELOG.md > >>>> [9]: > >>> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > >>>
