The ORC JNI wrapper is currently crashing on these lines:
https://github.com/apache/arrow/blob/master/cpp/src/jni/orc/jni_wrapper.cpp#L279-L281

because in C++, certain buffers can be omitted by passing a null
popinter (specifically the null bitmap, if there are no nulls).
Therefore `buffer` in the lines above is a null pointer.

(I tried replacing the null buffer with a 0-byte buffer: it crashes
further down the road...)

Since this code has been there since ARROW-4714 was committed, my
intuition is that the JNI ORC wrapper was only exercised in very
specific use cases where C++ buffers are never null.

My opinion is therefore that the ORC JNI tests should be ignored for
this release, and fixed later by some motivated developer.

Regards

Antoine.


Le 16/04/2020 à 02:17, Krisztián Szűcs a écrit :
> Hi,
> 
> We've merged the last required pull requests later today[/yesterday],
> so I started to cut RC0.
> The release process doesn't go smoothly, among other smaller problems
> I discovered a crash with the ORC Java JNI bindings (local error [1]),
> turned out that we don't run the orc-jni tests on the CI. I put up a PR
> to enable them [2], it has not reproduced the exact issue yet.
> 
> Any help from the JNI developers would be appreciated. I can also cut
> RC0 with JNI disabled.
> 
> [1] https://gist.github.com/kszucs/67205eda6cd19e3cd08c86894f5b4c2d
> [2] https://github.com/apache/arrow/pull/6953
> 
> Regards, Krisztian
> 

Reply via email to