Hey Micah! On Sun, Sep 29, 2019 at 10:23 PM Micah Kornfield <emkornfi...@gmail.com> wrote:
> Krisztián do you have availability to cut a new RC (I won't be able to > sort out my key issues for at least a week)? > Yes, I can cut RC2 later today. > > To answer Wes's question earlier in the thread it would be nice to include > the C# fix for file formats [1]. > > Thanks, > Micah > > [1] > https://github.com/apache/arrow/commit/5fec051d93a0e647c2330564d6d9eb0c7c896e48 > > On Sun, Sep 29, 2019 at 11:30 AM Micah Kornfield <emkornfi...@gmail.com> > wrote: > >> Im going to vote -1 on this RC. I think we should cut a new RC with >> someone who has verified key (I think it is the best thing from a security >> stand point). I didn't realize the noise that would be caused by lack of >> cross signing. I apologise for the churn. >> >> On Sunday, September 29, 2019, Andy Grove <andygrov...@gmail.com> wrote: >> >>> Just fyi on the rustfmt issue, the formatting was recently updated for >>> rust >>> 1.40 nightly and if you are using an older version the formatting check >>> will fail. >>> >>> On Sun, Sep 29, 2019, 5:56 AM Wes McKinney <wesmck...@gmail.com> wrote: >>> >>> > It's up to Micah as RM, but I think it would be good to fix the >>> sig-related >>> > issues or we may be dealing with "bug" reports until the next release. >>> I'll >>> > work on source verification later today in the meantime to see if any >>> other >>> > issues turn up >>> > >>> > On Sun, Sep 29, 2019, 1:19 AM Sutou Kouhei <k...@clear-code.com> wrote: >>> > >>> > > -0 (binding) >>> > > >>> > > I ran the followings on Debian GNU/Linux sid: >>> > > >>> > > * TEST_CSHARP=0 \ >>> > > TEST_GLIB=0 \ >>> > > TEST_RUBY=0 \ >>> > > TEST_RUST=0 \ >>> > > JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 \ >>> > > CUDA_TOOLKIT_ROOT=/usr \ >>> > > dev/release/verify-release-candidate.sh source 0.15.0 1 >>> > > * dev/release/verify-release-candidate.sh binaries 0.14.1 0 >>> > > >>> > > with: >>> > > >>> > > * gcc (Debian 9.2.1-7) 9.2.1 >>> > > * openjdk version "1.8.0_212" >>> > > * Node.JS v12.1.0 >>> > > * go version go1.12.9 linux/amd64 >>> > > * nvidia-cuda-dev 10.1.105-3 >>> > > >>> > > >>> > > I got the following failures: >>> > > >>> > > * Not ignorable: >>> > > * Binary: Bad signature >>> > > * centos-rc/6/Source/repodata/repomd.xml is failed >>> > > * We can't ignore this if removing the file from >>> > > https://bintray.com/apache/arrow/centos-rc/0.15.0-rc1 and >>> > > re-uploading it doesn't solve this problem. >>> > > >>> > > * Ignorable: >>> > > * C GLib and Ruby: Buildable but can't run test with GLib 2.62.0. >>> > > * It's caused by gobject-introspection gem. >>> > > * This is a known problem and not a C GLib problem. >>> > > * We can ignore this. (I'm fixing gobject-introspection gem.) >>> > > * Rust: "cargo +stable fmt --all -- --check" is failed (*) >>> > > * If I commented the command line out, Rust verification is >>> passed. >>> > > * We can ignore this. Because this is just a lint error. >>> > > * C#: "sourcelink test" is failed >>> > > * We can ignore this. This is happened when we release 0.14.1 >>> too. >>> > > * APT and Yum: arm64 and aarch64 are broken >>> > > * We can ignore this. >>> > > >>> > > (*) >>> > > ---- >>> > > + cargo +stable fmt --all -- --check >>> > > Diff in >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/arrow/src/array/ >>> > > builder.rs at line 1458: >>> > > let mut builder = StructBuilder::new(fields, >>> field_builders); >>> > > >>> assert!(builder.field_builder::<BinaryBuilder>(0).is_none()); >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/arrow/src/ >>> > > bitmap.rs at line 126: >>> > > assert_eq!(true, bitmap.is_set(6)); >>> > > assert_eq!(false, bitmap.is_set(7)); >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> > > >>> > >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/ >>> > > aggregate.rs at line 1471: >>> > > ds, >>> > > ))))) >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> > > >>> > >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/ >>> > > context.rs at line 682: >>> > > >>> > > Ok(ctx) >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> > > >>> > >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/physical_plan/ >>> > > hash_aggregate.rs at line 720: >>> > > >>> > > Ok(()) >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> > > >>> > >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/physical_plan/ >>> > > merge.rs at line 134: >>> > > >>> > > Ok(()) >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> > > >>> > >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/physical_plan/ >>> > > projection.rs at line 171: >>> > > >>> > > Ok(()) >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> > > >>> > >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/physical_plan/ >>> > > selection.rs at line 180: >>> > > >>> > > Ok(()) >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> > > >>> > >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/ >>> > > projection.rs at line 141: >>> > > >>> > > assert_eq!("c1", batch.schema().field(0).name()); >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> > > >>> > >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/ >>> > > table_impl.rs at line 315: >>> > > true, >>> > > ); >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/ >>> > > logicalplan.rs at line 641: >>> > > println!("plan: {:?}", plan1); >>> > > }); >>> > > } >>> > > - >>> > > } >>> > > >>> > > Diff in >>> > > /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/sql/ >>> > > planner.rs at line 569: >>> > > } >>> > > } >>> > > } >>> > > - >>> > > } >>> > > ---- >>> > > >>> > > >>> > > >>> > > Thanks, >>> > > -- >>> > > kou >>> > > >>> > > In < >>> cak7z5t9mamqwtobwmzmjv_tmhanwgmtndpcme+_rpqn3lse...@mail.gmail.com> >>> > > "Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1" on Fri, 27 Sep >>> 2019 >>> > > 02:18:05 -0600, >>> > > Micah Kornfield <emkornfi...@gmail.com> wrote: >>> > > >>> > > > Hi, >>> > > > >>> > > > >>> > > > I would like to propose the following release candidate (RC1) of >>> Apache >>> > > > >>> > > > Arrow version 0.15.0. This is a release consisting of 672 >>> > > > >>> > > > resolved JIRA issues[1]. (RC0 was aborted due to release script >>> > issues). >>> > > > >>> > > > >>> > > > This release candidate is based on commit: >>> > > > >>> > > > 77f091888dbe5a4e023a66b986a2dd474696061a [2] >>> > > > >>> > > > >>> > > > The source release rc1 is hosted at [3]. >>> > > > >>> > > > The binary artifacts are hosted at [4][5][6][7]. >>> > > > >>> > > > The changelog is located at [8]. >>> > > > >>> > > > >>> > > > Please download, verify checksums and signatures, run the unit >>> tests, >>> > > > >>> > > > and vote on the release. See [9] for how to validate a release >>> > candidate. >>> > > > >>> > > > >>> > > > The vote will be open for at least 72 hours. >>> > > > >>> > > > >>> > > > [ ] +1 Release this as Apache Arrow 0.15.0 >>> > > > >>> > > > [ ] +0 >>> > > > >>> > > > [ ] -1 Do not release this as Apache Arrow 0.15.0 because... >>> > > > >>> > > > >>> > > > [1]: >>> > > > >>> > > >>> > >>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%200.15.0 >>> > > > >>> > > > [2]: >>> > > > >>> > > >>> > >>> https://github.com/apache/arrow/tree/77f091888dbe5a4e023a66b986a2dd474696061a >>> > > > >>> > > > [3]: >>> > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.15.0-rc1 >>> > > > >>> > > > [4]: https://bintray.com/apache/arrow/centos-rc/0.15.0-rc1 >>> > > > >>> > > > [5]: https://bintray.com/apache/arrow/debian-rc/0.15.0-rc1 >>> > > > >>> > > > [6]: https://bintray.com/apache/arrow/python-rc/0.15.0-rc1 >>> > > > >>> > > > [7]: https://bintray.com/apache/arrow/ubuntu-rc/0.15.0-rc1 >>> > > > >>> > > > [8]: >>> > > > >>> > > >>> > >>> https://github.com/apache/arrow/blob/77f091888dbe5a4e023a66b986a2dd474696061a/CHANGELOG.md >>> > > > >>> > > > [9]: >>> > > > >>> > > >>> > >>> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates >>> > > >>> > >>> >>
