Ji Liu created ARROW-6311: ----------------------------- Summary: [Java] Make ApproxEqualsVisitor accept DiffFunction to make it more flexible Key: ARROW-6311 URL: https://issues.apache.org/jira/browse/ARROW-6311 Project: Apache Arrow Issue Type: Improvement Components: Java Reporter: Ji Liu Assignee: Ji Liu
Currently {{ApproxEqualsVisitor}} will accept a epsilon for both float and double compare, and the difference calculation is always {{Math.abs}}(f1-f2) For some cases like {{Validator}} it is not very suitable as: i. it has different epsilon values for float/double ii. it difference function is not Math.abs(f1-f2) To resolve these, make this visitor accept both float/double epsilons and diff functions. -- This message was sent by Atlassian Jira (v8.3.2#803003)