Thanks for your comment. Could you write this comment on the issue to track this discussion easily?
In <CAD+DX3hPUT6eHkLMrFoG62BGUT=ja3fixt8cpadjjiwfaxc...@mail.gmail.com> "Re: [jira] [Created] (ARROW-6232) [C++] Rename Argsort kernel to SortIndices" on Wed, 14 Aug 2019 15:18:19 +1000, Zhuo Jia Dai <[email protected]> wrote: > How about sortorder, or sort rank or rank_of_sort or similar > > On Wed., 14 Aug. 2019, 15:01 Sutou Kouhei (JIRA), <[email protected]> wrote: > >> Sutou Kouhei created ARROW-6232: >> ----------------------------------- >> >> Summary: [C++] Rename Argsort kernel to SortIndices >> Key: ARROW-6232 >> URL: https://issues.apache.org/jira/browse/ARROW-6232 >> Project: Apache Arrow >> Issue Type: Improvement >> Components: C++ >> Reporter: Sutou Kouhei >> Assignee: Sutou Kouhei >> >> >> "Argsort" is NumPy specific name. Other languages/libraries use >> different name: >> >> * R: order >> * >> https://cran.r-project.org/doc/manuals/r-release/fullrefman.pdf#Rfn.order >> >> * MATLAB: sort >> * https://mathworks.com/help/matlab/ref/sort.html >> * "sort" returns sorted array and indices to sort array >> >> * Julia: sortperm >> * >> https://pkg.julialang.org/docs/julia/THl1k/1.1.1/base/sort.html#Base.sortperm >> >> It's better that we use general name because Arrow C++ isn't a NumPy >> compatible library. >> >> "SortIndices" means "sort that returns indices array". We can add >> "SortValues" or something for sort kernel that returns values array. >> >> "SortIndices" may be easily mistaken for "sort by indices". >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v7.6.14#76016) >>
