I updated https://gist.github.com/wesm/1e4ac14baaa8b27bf13b071d2d715014 to include all the cited patches, as well as the Parquet forward compatibility fix.
I'm waiting on CI to be able to pass ARROW-5921 (fuzzing-discovered IPC crash) and the ARROW-5889 (Parquet backwards compatibility with 0.13) needs to be rebased https://github.com/apache/arrow/pull/4856 I think those are the last 2 patches that should go into the branch unless something else comes up. Once those land I'll update the commands and then push up the patch release branch (hopefully everything will cherry pick cleanly) On Fri, Jul 12, 2019 at 12:34 PM Francois Saint-Jacques <fsaintjacq...@gmail.com> wrote: > > There's also ARROW-5921 (I tagged it 0.14.1) if it passes travis. This > one fixes a segfault found via fuzzing. > > François > > On Fri, Jul 12, 2019 at 6:54 AM Krisztián Szűcs > <szucs.kriszt...@gmail.com> wrote: > > > > PRs touching the wheel packaging scripts: > > - https://github.com/apache/arrow/pull/4828 (lz4) > > - https://github.com/apache/arrow/pull/4833 (uriparser - only if > > https://github.com/apache/arrow/commit/88fcb096c4f24861bc7f8181cba1ad8be0e4048a > > is cherry picked as well) > > - https://github.com/apache/arrow/pull/4834 (zlib) > > > > On Fri, Jul 12, 2019 at 11:49 AM Hatem Helal <hhe...@mathworks.com> wrote: > > > > > Thanks François, I closed PARQUET-1623 this morning. It would be nice to > > > include the PR in the patch release: > > > > > > https://github.com/apache/arrow/pull/4857 > > > > > > This bug has been around for a few releases but I think it should be a low > > > risk change to include. > > > > > > Hatem > > > > > > > > > On 7/12/19, 2:27 AM, "Francois Saint-Jacques" <fsaintjacq...@gmail.com> > > > wrote: > > > > > > I just merged PARQUET-1623, I think it's worth inserting since it > > > fixes an invalid memory write. Note that I couldn't resolve/close the > > > parquet issue, do I have to be contributor to the project? > > > > > > François > > > > > > On Thu, Jul 11, 2019 at 6:10 PM Wes McKinney <wesmck...@gmail.com> > > > wrote: > > > > > > > > I just merged Eric's 2nd patch ARROW-5908 and I went through all the > > > > patches since the release commit and have come up with the following > > > > list of 32 fix-only patches to pick into a maintenance branch: > > > > > > > > https://gist.github.com/wesm/1e4ac14baaa8b27bf13b071d2d715014 > > > > > > > > Note there's still unresolved Parquet forward/backward compatibility > > > > issues in C++ that we haven't merged patches for yet, so that is > > > > pending. > > > > > > > > Are there any other patches / JIRA issues people would like to see > > > > resolved in a patch release? > > > > > > > > Thanks > > > > > > > > On Thu, Jul 11, 2019 at 3:03 PM Wes McKinney <wesmck...@gmail.com> > > > wrote: > > > > > > > > > > Eric -- you are free to set the Fix Version prior to the patch > > > being merged > > > > > > > > > > On Thu, Jul 11, 2019 at 3:01 PM Eric Erhardt > > > > > <eric.erha...@microsoft.com.invalid> wrote: > > > > > > > > > > > > The two C# fixes I'd like in the 0.14.1 release are: > > > > > > > > > > > > https://issues.apache.org/jira/browse/ARROW-5887 - already > > > marked with 0.14.1 fix version. > > > > > > https://issues.apache.org/jira/browse/ARROW-5908 - hasn't been > > > resolved yet. The PR https://github.com/apache/arrow/pull/4851 has one > > > approver and the Rust failure doesn't appear to be caused by my change. > > > > > > > > > > > > I assume I shouldn't mark ARROW-5908 with a 0.14.1 fix version > > > until the PR has been merged. > > > > > > > > > > > > -----Original Message----- > > > > > > From: Neal Richardson <neal.p.richard...@gmail.com> > > > > > > Sent: Thursday, July 11, 2019 11:59 AM > > > > > > To: dev@arrow.apache.org > > > > > > Subject: Re: [DISCUSS] Need for 0.14.1 release due to Python > > > package problems, Parquet forward compatibility problems > > > > > > > > > > > > I just moved > > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FARROW-5850&data=02%7C01%7CEric.Erhardt%40microsoft.com%7C244c0dd319dd4ea18a5508d7062125de%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636984611747771373&sdata=B6xfFcBu4Iz0jJE5tUXkKvoJx36kMCS4UJCdTV7jqGA%3D&reserved=0 > > > from 1.0.0 to 0.14.1. > > > > > > > > > > > > On Thu, Jul 11, 2019 at 8:12 AM Wes McKinney < > > > wesmck...@gmail.com> wrote: > > > > > > > > > > > > > To limit uncertainty, I'm going to start preparing a 0.14.1 > > > patch > > > > > > > release branch. I will update the list with the patches that > > > are being > > > > > > > cherry-picked. If other folks could give me a list of other > > > PRs that > > > > > > > need to be backported I will add them to the list. Any JIRA > > > that needs > > > > > > > to be included should have the "0.14.1" fix version added so > > > we can > > > > > > > keep track > > > > > > > > > > > > > > On Wed, Jul 10, 2019 at 9:48 PM Joris Van den Bossche > > > > > > > <jorisvandenboss...@gmail.com> wrote: > > > > > > > > > > > > > > > > I personally prefer 0.14.1 over 0.15.0. I think that is > > > clearer in > > > > > > > > communication, as we are fixing regressions of the 0.14.0 > > > release. > > > > > > > > > > > > > > > > (but I haven't been involved much in releases, so certainly > > > no > > > > > > > > strong > > > > > > > > opinion) > > > > > > > > > > > > > > > > Joris > > > > > > > > > > > > > > > > > > > > > > > > Op wo 10 jul. 2019 om 15:07 schreef Wes McKinney < > > > wesmck...@gmail.com>: > > > > > > > > > > > > > > > > > hi folks, > > > > > > > > > > > > > > > > > > Are there any opinions / strong feelings about the two > > > options: > > > > > > > > > > > > > > > > > > * Prepare patch 0.14.1 release from a maintenance branch > > > > > > > > > * Release 0.15.0 out of master > > > > > > > > > > > > > > > > > > Aside from the Parquet forward compatibility issues we're > > > still > > > > > > > > > discussing, and Eric's C# patch PR 4836, are there any > > > other > > > > > > > > > issues that need to be fixed before we go down one of > > > these paths? > > > > > > > > > > > > > > > > > > Would anyone like to help with release management? I can > > > do so if > > > > > > > > > necessary, but I've already done a lot of release > > > management :) > > > > > > > > > > > > > > > > > > - Wes > > > > > > > > > > > > > > > > > > On Tue, Jul 9, 2019 at 4:13 PM Wes McKinney < > > > wesmck...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > Hi Eric -- of course! > > > > > > > > > > > > > > > > > > > > On Tue, Jul 9, 2019, 4:03 PM Eric Erhardt < > > > > > > > eric.erha...@microsoft.com.invalid> > > > > > > > > > wrote: > > > > > > > > > >> > > > > > > > > > >> Can we propose getting changes other than Python or > > > Parquet > > > > > > > > > >> related > > > > > > > > > into this release? > > > > > > > > > >> > > > > > > > > > >> For example, I found a critical issue in the C# > > > implementation > > > > > > > that, if > > > > > > > > > possible, I'd like to get included in a patch release. > > > > > > > > > > > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2F > > > > > > > > > github.com > > > %2Fapache%2Farrow%2Fpull%2F4836&data=02%7C01%7CEric. > > > > > > > > > Erhardt%40microsoft.com > > > %7C244c0dd319dd4ea18a5508d7062125de%7C72f98 > > > > > > > > > > > > 8bf86f141af91ab2d7cd011db47%7C1%7C0%7C636984611747781365&sdata > > > > > > > > > > > > =5wJ%2FGdh8LTxRyrB%2F2Lc3ue46%2FRqE6WUM6brsSDv2FR0%3D&reserved > > > > > > > > > =0 > > > > > > > > > >> > > > > > > > > > >> Eric > > > > > > > > > >> > > > > > > > > > >> -----Original Message----- > > > > > > > > > >> From: Wes McKinney <wesmck...@gmail.com> > > > > > > > > > >> Sent: Tuesday, July 9, 2019 7:59 AM > > > > > > > > > >> To: dev@arrow.apache.org > > > > > > > > > >> Subject: Re: [DISCUSS] Need for 0.14.1 release due to > > > Python > > > > > > > > > >> package > > > > > > > > > problems, Parquet forward compatibility problems > > > > > > > > > >> > > > > > > > > > >> On Tue, Jul 9, 2019 at 12:02 AM Sutou Kouhei > > > > > > > > > >> <k...@clear-code.com> > > > > > > > > > wrote: > > > > > > > > > >> > > > > > > > > > > >> > Hi, > > > > > > > > > >> > > > > > > > > > > >> > > If the problems can be resolved quickly, I should > > > think we > > > > > > > could cut > > > > > > > > > >> > > an RC for 0.14.1 by the end of this week. The RC > > > could > > > > > > > > > >> > > either > > > > > > > be cut > > > > > > > > > >> > > from a maintenance branch or out of master -- any > > > thoughts > > > > > > > > > >> > > about this (cutting from master is definitely > > > easier)? > > > > > > > > > >> > > > > > > > > > > >> > How about just releasing 0.15.0 from master? > > > > > > > > > >> > It'll be simpler than creating a patch release. > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> I'd be fine with that, too. > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > >> > Thanks, > > > > > > > > > >> > -- > > > > > > > > > >> > kou > > > > > > > > > >> > > > > > > > > > > >> > In <CAJPUwMBPaz7zLBkBcVo-r= > > > > > > > > > nmvwuy8wxxddcctobuuamy4ee...@mail.gmail.com> > > > > > > > > > >> > "[DISCUSS] Need for 0.14.1 release due to Python > > > package > > > > > > > problems, > > > > > > > > > Parquet forward compatibility problems" on Mon, 8 Jul 2019 > > > > > > > > > 11:32:07 > > > > > > > -0500, > > > > > > > > > >> > Wes McKinney <wesmck...@gmail.com> wrote: > > > > > > > > > >> > > > > > > > > > > >> > > hi folks, > > > > > > > > > >> > > > > > > > > > > > >> > > Perhaps unsurprisingly due to the expansion of our > > > Python > > > > > > > packages, > > > > > > > > > >> > > a number of things are broken in 0.14.0 that we > > > should fix > > > > > > > sooner > > > > > > > > > >> > > than the next major release. I'll try to send a > > > complete > > > > > > > > > >> > > list to this thread to give a status within a day > > > or two. > > > > > > > > > >> > > Other > > > > > > > problems may > > > > > > > > > >> > > arise in the next 48 hours as more people install > > > the package. > > > > > > > > > >> > > > > > > > > > > > >> > > If the problems can be resolved quickly, I should > > > think we > > > > > > > could cut > > > > > > > > > >> > > an RC for 0.14.1 by the end of this week. The RC > > > could > > > > > > > > > >> > > either > > > > > > > be cut > > > > > > > > > >> > > from a maintenance branch or out of master -- any > > > thoughts > > > > > > > > > >> > > about this (cutting from master is definitely > > > easier)? > > > > > > > > > >> > > > > > > > > > > > >> > > Would someone (who is not Kou) be able to assist > > > with > > > > > > > > > >> > > creating > > > > > > > the > > > > > > > > > RC? > > > > > > > > > >> > > > > > > > > > > > >> > > Thanks, > > > > > > > > > >> > > Wes > > > > > > > > > > > > > > > > > > > > > > > > >
