Sounds good Micah. On Fri, Jun 14, 2019 at 11:08 AM Ravindra Pindikura <ravin...@dremio.com> wrote:
> +1 > > On Fri, Jun 14, 2019 at 9:51 AM Micah Kornfield <emkornfi...@gmail.com> > wrote: > > > I'm in favor of the changes also, but since they affect the entire Java > > codebase I wanted people to be aware of them in case there are any > > objections. I plan to merge the PR tomorrow evening Past or over the > > weekend unless someone voices an objection. > > > > Thanks, > > Micah > > > > On Thursday, June 13, 2019, Fan Liya <liya.fa...@gmail.com> wrote: > > > > > +1 for removing unused imports > > > > > > On Fri, Jun 14, 2019 at 11:25 AM niki.lj <niki...@aliyun.com.invalid> > > > wrote: > > > > > >> Hi all, > > >> We recently discovered that style check rules for Java code could be > > >> enhanced, for example, "unused imports" and "redundant modifier" > checks > > are > > >> not included before. > > >> I created ARROW-5587 and submitted a PR (https://github.com/apache/ > > >> arrow/pull/4567) for this, and open this thread according to the > > >> comments of @Micah Kornfield. > > >> If you have any different ideas, please let me know. Thanks! > > >> > > >> Best, > > >> Ji Liu > > >> > > >> > > > > > -- > Thanks and regards, > Ravindra. >
