0 (non-binding) The verification script doesn't compile out of the box on ubuntu 18.04 (fixed by forcing ARROW_DEPENDENCY_SOURCE=BUNDLE). Afterward, I hit a failure I can't reproduce out of the verification script, e.g. in a local build with/without conda.
1: /tmp/arrow-0.13.0.Q4czW/apache-arrow-0.13.0/cpp/src/plasma/test/serialization_tests.cc:193: Failure 1: Expected equality of these values: 1: memcmp(&plasma_objects[object_ids[0]], &plasma_objects_return[0], sizeof(PlasmaObject)) 1: Which is: 45 1: 0 1: [ FAILED ] PlasmaSerialization.GetReply (0 ms) Note that the source of the failure indicate a bad test and not a bad implementation of what's being tested. Opened https://issues.apache.org/jira/browse/ARROW-5028 . I'm not sure this should block the release, but since Antoine already objected. On Wed, Mar 27, 2019 at 9:55 AM Antoine Pitrou <anto...@python.org> wrote: > > Hi, > > Le 27/03/2019 à 12:36, Kouhei Sutou a écrit : > > Hi, > > > > I would like to propose the following release candidate (RC3) of Apache > > Arrow version 0.13.0. This is a release consiting of 584 > > resolved JIRA issues[1]. > > > > This release candidate is based on commit: > > 6de758a9e5f74d50ec3458b2af17b7d2d892c573 [2] > > > > The source release rc3 is hosted at [3]. > > The binary artifacts are hosted at [4][5][6][7]. > > The changelog is located at [8]. > > > > Please download, verify checksums and signatures, run the unit tests, > > and vote on the release. See [9] for how to validate a release candidate. > > I verified the binaries on Ubuntu 18.04 (x86-64). > > However, source verification failed with the following messages during > the C++ build: > > CMake Error at > /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 > (message): > Could NOT find DoubleConversion (missing: DoubleConversion_LIB > DoubleConversion_INCLUDE_DIR) > Call Stack (most recent call first): > /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 > (_FPHSA_FAILURE_MESSAGE) > cmake_modules/FindDoubleConversion.cmake:35 > (find_package_handle_standard_args) > cmake_modules/ThirdpartyToolchain.cmake:507 (find_package) > CMakeLists.txt:544 (include) > > > Regards > > Antoine. >
