Areg Melik-Adamyan created ARROW-4462:
-----------------------------------------

             Summary: Upgrade LZ4 v1.7.5 to v1.8.3 to compile with VS2017
                 Key: ARROW-4462
                 URL: https://issues.apache.org/jira/browse/ARROW-4462
             Project: Apache Arrow
          Issue Type: Improvement
          Components: Developer Tools
            Reporter: Areg Melik-Adamyan


By upgrading to LZ4 v1.8.3 the patch and patching step can be removed as it is 
incorporated into a newer version of VS2010 solution and also VS2017 solution 
is provided which ease the usage with newer versions. Is there a reason or 
fixed dependency on v1.7.5?

There is still an issue with newer than v8.1 MS Build Tools, and requires 
manual retargeting. Which can be fixed in CMake by introducing complex logic of 
reading registry tree 
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\MSBuild\ToolsVersions\4.0\1*.0 and 
analyzing which version of tools are installed and then patching the solution 
and projects. But as this is an external dependency better to submit patch 
there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to