Looks like we have a majority. I just filed a PR [1] for this. One thing though is that the "comment_width" flag is only available in nightly, so there's no easy way to check that unless we use the nightly rustfmt checker.
Chao [1]: https://github.com/apache/arrow/pull/3501 On Fri, Jan 25, 2019 at 5:43 PM paddy horan <paddyho...@hotmail.com> wrote: > +1 from me > > Get Outlook for iOS<https://aka.ms/o0ukef> > > ________________________________ > From: Renjie Liu <liurenjie2...@gmail.com> > Sent: Friday, January 25, 2019 7:49 PM > To: dev@arrow.apache.org > Subject: Re: [Rust] code style: restrict line width to 90 characters? > > +1 for this suggestio. > > Chao Sun <sunc...@apache.org> 于 2019年1月26日周六 上午2:39写道： > > > Hi Neville, there's no limit today: you'll need to add > > > > max_width = 90 > > comment_width = 90 > > > > to rustfmt.toml to limit both source code and comment to 90 characters. > > > > Chao > > > > On Fri, Jan 25, 2019 at 10:34 AM Neville Dipale <nevilled...@gmail.com> > > wrote: > > > > > Hi Chao, > > > > > > What's the current limit? I just ran rustfmt, and seems like it's not > > > reformatting at 100 characters. I support changing whatever the current > > > width is to 90 characters. > > > > > > Regards > > > Neville > > > > > > On Fri, 25 Jan 2019 at 19:49, Chao Sun <sunc...@apache.org> wrote: > > > > > > > Hi Rust developers, > > > > > > > > Just want to know if anyone like the idea to restrict the line width > to > > > 90 > > > > characters for Rust, similar to the C++ coding style. Personally I > > found > > > it > > > > helpful when you need to keep multiple windows in a monitor. This can > > > > easily be enforced via rustfmt. If there's no objection, I can open a > > > JIRA > > > > for this and apply the change to the existing codebase. > > > > > > > > Thanks, > > > > Chao > > > > > > > > > >
