+1 (non-binding) I didn't do very exhaustive tests, but the full Ray test suite passes based on that commit.
On Sun, Jan 13, 2019 at 8:59 PM Wes McKinney <wesmck...@gmail.com> wrote: > +1 (binding) > > Ran release verification scripts (for source release) on Ubuntu 14.04 > (with ARROW_HAVE_CUDA=yes) and Windows / Visual Studio 2015 with some > caveats > > * ARROW-4250: Gandiva test failing due to exact floating point > comparison on Ubuntu 14.04 > * ARROW-4253: GLib cannot use a non-system Boost > * ARROW-4254: Ubuntu 14.04 Boost from apt has compilation errors in > Gandiva unit tests > * ARROW-4256: Windows verification script fix (patch up) > * ARROW-4257: Update release verification script now that the staged > binaries are on Bintray > > None of these issues are very significant. I hope we can work toward a > more smooth 0.13 release > > On Sun, Jan 13, 2019 at 10:14 AM Andy Grove <andygrov...@gmail.com> wrote: > > > > Speaking for the Rust implementation only ... > > > > - The code compiles and tests pass > > - The version number of both crates (arrow and parquet) is correctly set > to > > 0.12.0 > > - The parquet crate still depends on the arrow crate using a local path > > (../arrow) rather than depending on the published 0.12.0 (which doesn't > > exist yet) so technically cannot be published as is (but we can manually > > change that dependency when publishing, so I don't see it as a big deal > at > > all) > > > > So it's a +1 from me. > > > > Andy. > > > > On Sat, Jan 12, 2019 at 12:56 PM Krisztián Szűcs < > szucs.kriszt...@gmail.com> > > wrote: > > > > > Hi, > > > > > > I'd like to propose the 1st release candidate (RC2) of Apache Arrow > version > > > 0.12.0. This is a major release consisting of 600 resolved JIRAs [1]. > > > The previous RCs were not voted, because: > > > - RC0: the source archive didn't include required files to build > > > gandiva-glib > > > documents, also causing failed binary build for Debian Stretch [6]. > > > - RC1: compatibility issues with the just released pandas version > 0.24.rc1 > > > [8] > > > > > > This release candidate is based on commit: > > > 0bbaef451ae9d59799e693df9b2383808516a326 [2] > > > > > > The source release rc2 is hosted at [3]. > > > The binary artifacts are hosted at [4]. > > > The changelog is located at [5]. > > > > > > Please download, verify checksums and signatures, run the unit tests, > > > and vote on the release. See [7] for how to validate a release > candidate. > > > > > > The vote will be open for at least 72 hours. > > > > > > [ ] +1 Release this as Apache Arrow 0.12.0 > > > [ ] +0 > > > [ ] -1 Do not release this as Apache Arrow 0.12.0 because... > > > > > > Special thanks to @kou for helping with the uprising issues! > > > > > > - Krisztian > > > > > > [1]: > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%200.12.0 > > > [2]: > > > > > > > https://github.com/apache/arrow/commit/0bbaef451ae9d59799e693df9b2383808516a326 > > > < > > > > https://github.com/apache/arrow/tree/5ac58233936fcd2213c23adce72a79911c3f1359 > > > > > > > [3]: > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.12.0-rc2/ > > > [4]: https://bintray.com/beta/#/apache/arrow?tab=packages > > > [5]: > > > > > > > https://github.com/apache/arrow/blob/0bbaef451ae9d59799e693df9b2383808516a326/CHANGELOG.md > > > [6]: https://travis-ci.org/kszucs/crossbow/builds/478393330 > > > [7]: > > > > > > > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > > [8]: https://travis-ci.org/kszucs/crossbow/builds/478558640 > > > >