Thanks. I'll give that a go if/when I need to build thrift. Romain
> Le 2 janv. 2019 à 17:07, Wes McKinney <wesmck...@gmail.com> a écrit : > > You stumbled on https://issues.apache.org/jira/browse/PARQUET-1319. > See > https://github.com/apache/parquet-cpp/commit/d15d2687e9f154e69e956e2a56c8d1fd6c3b7ac8 > (which is part of Arrow's ThirdpartyToolchain.cmake) > > You can pass `-DBISON_EXECUTABLE=/path/to/homebrew/bison` when building > > - Wes > > On Wed, Jan 2, 2019 at 7:20 AM Romain Francois <rom...@purrple.cat> wrote: >> >> Turns out I already have a thrift installed through brew, but cmake needed >> help to figure it out, I have added >> >> export THRIFT_HOME="/usr/local/Cellar/thrift/0.11.0" >> >> to my ~/.bash_profile >> >> >>> Le 2 janv. 2019 à 14:00, Romain Francois <rom...@purrple.cat> a écrit : >>> >>> This might be relevant, I'm getting: >>> >>> -- THRIFT_HOME: >>> -- Thrift compiler/libraries NOT found: (THRIFT_INCLUDE_DIR-NOTFOUND, >>> THRIFT_STATIC_LIB-NOTFOUND). Looked in system search paths. >>> -- Thrift include dir: >>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep/src/thrift_ep-install/include >>> -- Thrift static library: >>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep/src/thrift_ep-install/lib/libthrift.a >>> -- Thrift compiler: >>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep/src/thrift_ep-install/bin/thrift >>> >>> As part of the cmake (full below). I have a brew installed thrift, maybe >>> this is not picked up ? >>> >>> Romain >>> >>> >>> >>> romain@purrplex ~/git/apache/arrow/cpp/release $ cmake .. >>> -DARROW_PARQUET=ON -DCMAKE_BUILD_TYPE=Release >>> -DARROW_BOOST_USE_SHARED:BOOL=Off >>> -- Building using CMake version: 3.13.2 >>> -- The C compiler identification is AppleClang 10.0.0.10001044 >>> -- The CXX compiler identification is AppleClang 10.0.0.10001044 >>> -- Check for working C compiler: >>> /Library/Developer/CommandLineTools/usr/bin/cc >>> -- Check for working C compiler: >>> /Library/Developer/CommandLineTools/usr/bin/cc -- works >>> -- Detecting C compiler ABI info >>> -- Detecting C compiler ABI info - done >>> -- Detecting C compile features >>> -- Detecting C compile features - done >>> -- Check for working CXX compiler: >>> /Library/Developer/CommandLineTools/usr/bin/c++ >>> -- Check for working CXX compiler: >>> /Library/Developer/CommandLineTools/usr/bin/c++ -- works >>> -- Detecting CXX compiler ABI info >>> -- Detecting CXX compiler ABI info - done >>> -- Detecting CXX compile features >>> -- Detecting CXX compile features - done >>> -- Arrow version: 0.12.0 (full: '0.12.0-SNAPSHOT') >>> -- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.29.2") >>> clang-tidy not found >>> clang-format found at /usr/local/opt/llvm@6/bin/clang-format >>> infer not found >>> -- Found cpplint executable at >>> /Users/romain/git/apache/arrow/cpp/build-support/cpplint.py >>> -- Compiler command: env LANG=C >>> /Library/Developer/CommandLineTools/usr/bin/c++ -v >>> -- Compiler version: Apple LLVM version 10.0.0 (clang-1000.10.44.4) >>> Target: x86_64-apple-darwin18.2.0 >>> Thread model: posix >>> InstalledDir: /Library/Developer/CommandLineTools/usr/bin >>> >>> -- Compiler id: AppleClang >>> Selected compiler clang 4.1.0svn >>> -- Performing Test CXX_SUPPORTS_SSE4_2 >>> -- Performing Test CXX_SUPPORTS_SSE4_2 - Success >>> -- Performing Test CXX_SUPPORTS_ALTIVEC >>> -- Performing Test CXX_SUPPORTS_ALTIVEC - Success >>> -- Performing Test CXX_SUPPORTS_ARMCRC >>> -- Performing Test CXX_SUPPORTS_ARMCRC - Failed >>> Configured for RELEASE build (set with cmake >>> -DCMAKE_BUILD_TYPE={release,debug,...}) >>> -- Build Type: RELEASE >>> -- BOOST_VERSION: 1.67.0 >>> -- BROTLI_VERSION: v0.6.0 >>> -- DOUBLE_CONVERSION_VERSION: v3.1.1 >>> -- FLATBUFFERS_VERSION: 02a7807dd8d26f5668ffbbec0360dc107bbfabd5 >>> -- GBENCHMARK_VERSION: v1.4.1 >>> -- GFLAGS_VERSION: v2.2.0 >>> -- GLOG_VERSION: v0.3.5 >>> -- GRPC_VERSION: v1.14.1 >>> -- GTEST_VERSION: 1.8.0 >>> -- JEMALLOC_VERSION: 17c897976c60b0e6e4f4a365c751027244dada7a >>> -- LZ4_VERSION: v1.7.5 >>> -- ORC_VERSION: 1.5.1 >>> -- PROTOBUF_VERSION: v3.6.1 >>> -- RAPIDJSON_VERSION: v1.1.0 >>> -- RE2_VERSION: 2018-10-01 >>> -- SNAPPY_VERSION: 1.1.3 >>> -- THRIFT_VERSION: 0.11.0 >>> -- ZLIB_VERSION: 1.2.8 >>> -- ZSTD_VERSION: v1.3.7 >>> -- Found pthread: /usr/lib/libpthread.dylib >>> -- Boost version: 1.68.0 >>> -- Found the following Boost libraries: >>> -- regex >>> -- system >>> -- filesystem >>> -- Boost include dir: /usr/local/include >>> -- Boost libraries: >>> /usr/local/lib/libboost_regex-mt.a/usr/local/lib/libboost_system-mt.a/usr/local/lib/libboost_filesystem-mt.a >>> Added static library dependency boost_system_static: >>> /usr/local/lib/libboost_system-mt.a >>> Added static library dependency boost_filesystem_static: >>> /usr/local/lib/libboost_filesystem-mt.a >>> Added static library dependency boost_regex_static: >>> /usr/local/lib/libboost_regex-mt.a >>> Added static library dependency double-conversion_static: >>> /Users/romain/git/apache/arrow/cpp/release/double-conversion_ep/src/double-conversion_ep/lib/libdouble-conversion.a >>> -- double-conversion include dir: >>> /Users/romain/git/apache/arrow/cpp/release/double-conversion_ep/src/double-conversion_ep/include >>> -- double-conversion static library: >>> /Users/romain/git/apache/arrow/cpp/release/double-conversion_ep/src/double-conversion_ep/lib/libdouble-conversion.a >>> -- RapidJSON include dir: >>> /Users/romain/git/apache/arrow/cpp/release/src/rapidjson_ep/include >>> -- Flatbuffers include dir: >>> /Users/romain/git/apache/arrow/cpp/release/flatbuffers_ep-prefix/src/flatbuffers_ep-install/include >>> -- Flatbuffers compiler: >>> /Users/romain/git/apache/arrow/cpp/release/flatbuffers_ep-prefix/src/flatbuffers_ep-install/bin/flatc >>> Added static library dependency jemalloc_static: >>> /Users/romain/git/apache/arrow/cpp/release/jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc_pic.a >>> Added shared library dependency jemalloc_shared: >>> /Users/romain/git/apache/arrow/cpp/release/jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc.dylib >>> -- Found hdfs.h at: >>> /Users/romain/git/apache/arrow/cpp/thirdparty/hadoop/include/hdfs.h >>> -- Checking for module 'zlib' >>> -- Found zlib, version 1.2.11 >>> -- Found the ZLIB shared library: /usr/lib/libz.dylib >>> Added shared library dependency zlib_shared: /usr/lib/libz.dylib >>> Added static library dependency snappy_static: >>> /Users/romain/git/apache/arrow/cpp/release/snappy_ep/src/snappy_ep-install/lib/libsnappy.a >>> Added static library dependency brotli_enc_static: >>> /Users/romain/git/apache/arrow/cpp/release/brotli_ep/src/brotli_ep-install/lib//libbrotlienc.a >>> Added static library dependency brotli_dec_static: >>> /Users/romain/git/apache/arrow/cpp/release/brotli_ep/src/brotli_ep-install/lib//libbrotlidec.a >>> Added static library dependency brotli_common_static: >>> /Users/romain/git/apache/arrow/cpp/release/brotli_ep/src/brotli_ep-install/lib//libbrotlicommon.a >>> Added static library dependency lz4_static: >>> /Users/romain/git/apache/arrow/cpp/release/lz4_ep-prefix/src/lz4_ep/lib/liblz4.a >>> Added static library dependency zstd_static: >>> /Users/romain/git/apache/arrow/cpp/release/zstd_ep-install/lib/libzstd.a >>> -- THRIFT_HOME: >>> -- Thrift compiler/libraries NOT found: (THRIFT_INCLUDE_DIR-NOTFOUND, >>> THRIFT_STATIC_LIB-NOTFOUND). Looked in system search paths. >>> -- Thrift include dir: >>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep/src/thrift_ep-install/include >>> -- Thrift static library: >>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep/src/thrift_ep-install/lib/libthrift.a >>> -- Thrift compiler: >>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep/src/thrift_ep-install/bin/thrift >>> -- GLOG_CMAKE_CXX_FLAGS: -Qunused-arguments -O3 -DNDEBUG -fPIC -pthread >>> -- CMAKE_CXX_FLAGS in glog: -Qunused-arguments -O3 -DNDEBUG -fPIC -pthread >>> -- Glog version: v0.3.5 >>> -- Glog include dir: >>> /Users/romain/git/apache/arrow/cpp/release/glog_ep-prefix/src/glog_ep/include >>> -- Glog static library: >>> /Users/romain/git/apache/arrow/cpp/release/glog_ep-prefix/src/glog_ep/lib/libglog.a >>> Added static library dependency glog_static: >>> /Users/romain/git/apache/arrow/cpp/release/glog_ep-prefix/src/glog_ep/lib/libglog.a >>> -- CMAKE_C_FLAGS: -Qunused-arguments -O3 -DNDEBUG -Wall >>> -Wno-unknown-warning-option -msse4.2 -maltivec -stdlib=libc++ >>> -- CMAKE_CXX_FLAGS: -Qunused-arguments -O3 -DNDEBUG -Wall >>> -Wno-unknown-warning-option -msse4.2 -maltivec -stdlib=libc++ >>> -- Looking for backtrace >>> -- Looking for backtrace - found >>> -- backtrace facility detected in default set of libraries >>> -- Found Backtrace: >>> /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include >>> -- Configuring done >>> CMake Warning (dev): >>> Policy CMP0068 is not set: RPATH settings on macOS do not affect >>> install_name. Run "cmake --help-policy CMP0068" for policy details. Use >>> the cmake_policy command to set the policy and suppress this warning. >>> >>> For compatibility with older versions of CMake, the install_name fields for >>> the following targets are still affected by RPATH settings: >>> >>> arrow_shared >>> parquet_shared >>> >>> This warning is for project developers. Use -Wno-dev to suppress it. >>> >>> -- Generating done >>> -- Build files have been written to: >>> /Users/romain/git/apache/arrow/cpp/release >>> >>> >>>> Le 2 janv. 2019 à 13:41, Romain Francois <rom...@purrple.cat> a écrit : >>>> >>>> Hello, >>>> >>>> I'm trying to build arrow and parquet on Mac OS: >>>> >>>> $ cmake .. -DARROW_PARQUET=ON -DCMAKE_BUILD_TYPE=Release >>>> -DARROW_BOOST_USE_SHARED:BOOL=Off >>>> $ make install >>>> >>>> And get only up to: >>>> >>>> [ 37%] Performing build step for 'thrift_ep' >>>> CMake Error at >>>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep-prefix/src/thrift_ep-stamp/thrift_ep-build-RELEASE.cmake:16 >>>> (message): >>>> Command failed: 2 >>>> >>>> '/Library/Developer/CommandLineTools/usr/bin/make' >>>> >>>> See also >>>> >>>> >>>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep-prefix/src/thrift_ep-stamp/thrift_ep-build-*.log >>>> >>>> >>>> >>>> Which contains: >>>> >>>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.1-5: >>>> invalid directive: `%code' >>>> /Users/romain/git/apache/arrow/cpp/release/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.7-14: >>>> syntax error, unexpected identifier >>>> make[5]: *** [compiler/cpp/thrift/thrifty.cc] Error 1 >>>> make[4]: *** [compiler/cpp/CMakeFiles/parse.dir/all] Error 2 >>>> make[3]: *** [all] Error 2 >>>> >>>> I have bison 3.2.4 and flex 2.6.4 on my $PATH: >>>> >>>> romain@purrplex ~/git/apache/arrow/cpp/release $ bison --version >>>> bison (GNU Bison) 3.2.4 >>>> Written by Robert Corbett and Richard Stallman. >>>> >>>> Copyright (C) 2018 Free Software Foundation, Inc. >>>> This is free software; see the source for copying conditions. There is NO >>>> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. >>>> >>>> romain@purrplex ~/git/apache/arrow/cpp/release $ flex --version >>>> flex 2.6.4 >>>> >>> >>
