Hi Laurent, Thanks for your review comments. We have completed the code changes and merged as well. I have replied to few your comments. Please take a look when you get a chance.
Regards, -Atul -----Original Message----- From: Laurent Goujon [mailto:laur...@dremio.com] Sent: Wednesday, May 30, 2018 5:38 AM To: dev@arrow.apache.org Subject: Re: JDBC Adapter PR - 1759 Same here. On Tue, May 29, 2018 at 9:59 AM, Siddharth Teotia <siddha...@dremio.com> wrote: > Hi Atul, > > I will take a look today. > > Thanks, > Sidd > > On Tue, May 29, 2018 at 2:45 AM, Atul Dambalkar < > atul.dambal...@xoriant.com> > wrote: > > > Hi Sid, Laurent, Uwe, > > > > Any idea when can someone take a look at the PR > https://github.com/apache/ > > arrow/pull/1759/. > > > > Laurent had given bunch of comments earlier and now we have taken > > care of most of those. We have also added multiple test cases. It > > will be great > if > > someone can take a look. > > > > Regards, > > -Atul > > > > >
