I am in the middle of a simple prototype that has the basic implementation of BaseFixedWidthVector, FixedValueVectorsPrototype.java (template) to generate a simple IntVector using the proposal mentioned in the document.
I have realized that even though the LOCs in existing templates are reduced by 30-40% since bunch of common/basic functionality is moved to super class BaseFixedWidthVector, the major source of pain (giant and complex if conditions) associated with code generation is in accessor and mutator which is still part of templates. I am trying to err on the side of not using templates at all since I feel there is not much of gain from this refactoring project if the code in templates is still complex and requires regular addition/modification when adding new types. We are probably better off writing multiple sub classes (with duplicate code as applicable) Thoughts? I can create a PR from this prototype code once it in reasonable shape for review but was wondering if people have any opinion. Thanks, Sidd On Tue, Oct 3, 2017 at 3:16 AM, Siddharth Teotia <siddha...@dremio.com> wrote: > Hi All, > > You should have received an invitation to edit the following document. > Please feel free to add comments or additional content. > > https://docs.google.com/document/d/1rl0PK5OnbQAnFUrhd4bQPtP0u7930 > sBKKaiyggOY7t4/edit > > Let me know if the document is not editable. > > Thanks, > Siddharth >
