[
https://issues.apache.org/jira/browse/ARROW-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284151#comment-15284151
]
Wes McKinney commented on ARROW-200:
------------------------------------
agreed -- though it's likely if {{make_pystring}} returns NULL that a Python
error state was set. In which case the function should bail out immediately
> [Python] Convert Values String looks like it has incorrect error handling
> -------------------------------------------------------------------------
>
> Key: ARROW-200
> URL: https://issues.apache.org/jira/browse/ARROW-200
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Reporter: Micah Kornfield
> Assignee: Micah Kornfield
>
> In pyarrow/adapters/pandas.cc:
> There looks like there are at least a couple of instances of code of this sort
> `693 out_values[i] = make_pystring(data, length);
> 694 if (out_values[i] == nullptr) {
> 695 return Status::OK();
> 696 }`
> I believe this should be returning an error status. [~wesmckinn]?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
