+1. I think `batch processor` is good for me. Thanks, Ming Wen Twitter: _WenMing
YuanSheng Wang <[email protected]> 于2020年3月31日周二 下午10:05写道： > > > On Tue, Mar 31, 2020 at 8:07 PM Ayeshmantha Perera < > [email protected]> wrote: > >> @YuanSheng Wang <[email protected]> @Ming Wen <[email protected]> >> What do you think shall we remove the Async support of the Kafka library >> and move forward with the internal buffering >> > > agree +1 > > ^_^ > > >> >> On Tue, Mar 31, 2020 at 2:05 PM Ayeshmantha Perera < >> [email protected]> wrote: >> >>> Yeah that is a good idea >>> >>> On Tue, Mar 31, 2020 at 12:59 PM Nirojan Selvanathan <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> I created a PR to use the batch processor which executes only one-timer >>>> between the `buffer_duration`. I guess this can be used to resolve the >>>> problem. >>>> >>>> https://github.com/apache/incubator-apisix/pull/1358 >>>> >>>> >>>> On Tue, Mar 31, 2020 at 12:10 PM Zexuan Luo <[email protected]> >>>> wrote: >>>> >>>> > I think the code is used to work around the 'cosocket API disabled' >>>> > limitation in log phase. >>>> > I agree with you that we should take care about the max of the timers. >>>> > Perhaps, we can buffer the data and use constant number of timer to >>>> flush >>>> > it? >>>> > >>>> > ~Jarvis.Qiu <[email protected]> 于2020年3月31日周二 下午6:00写道： >>>> > >>>> > > the code in: >>>> > > >>>> > >>>> https://github.com/apache/incubator-apisix/blob/master/lua/apisix/plugins/kafka-logger.lua#L101 >>>> > > >>>> > > The limit of lua_max_pending_timers and lua_max_running_timers that >>>> may >>>> > be >>>> > > reached. >>>> > >>>> >>>> >>>> -- >>>> Best Regards, >>>> S.Nirojan >>>> >>>> Research Engineer >>>> Linked-in: https://www.linkedin.com/in/niroselva/ >>>> Mobile : (+94) 779823445 / 067763149095 >>>> >>> >>> >>> -- >>> *Software Engineer* >>> *Salzburg Research Forschungsgesellschaft * >>> *Salzburg, Austria* >>> >> >> >> -- >> *Software Engineer* >> *Salzburg Research Forschungsgesellschaft * >> *Salzburg, Austria* >> > > > -- > *MembPhis* > My github: https://github.com/membphis > Apache APISIX: https://github.com/apache/incubator-apisix >
