maartenc commented on code in PR #124:
URL: https://github.com/apache/ant-ivy/pull/124#discussion_r3438548466
##########
test/java/org/apache/ivy/ant/ivy-extends-merged.xml:
##########
@@ -31,22 +31,22 @@
<conf name="extra"/>
<!-- overrides conf in parent -->
<conf name="default" extends="compile" description="overrides
the conf definition in parent descriptor"/>
-
+
<!-- configurations inherited from apache#resolve-simple;1.0 -->
<conf name="compile" visibility="public"/>
</configurations>
<publications/>
<dependencies>
+ <!-- dependencies inherited from apache#resolve-simple;1.0 -->
+ <dependency org="org1" name="mod1.2" rev="2.0"
conf="default->default"/>
+ <dependency org="org1" name="mod1.1" rev="2.0"
transitive="false" conf="compile->default"/>
+ <!-- dependencies inherited end -->
Review Comment:
maybe add an empty line here between the dependencies from the parent and
the child module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
