jacodg commented on code in PR #224:
URL: https://github.com/apache/ant/pull/224#discussion_r2419129056
##########
src/main/org/apache/tools/ant/taskdefs/Get.java:
##########
@@ -90,9 +86,9 @@ public class Get extends Task {
private boolean tryGzipEncoding = false;
private Mapper mapperElement = null;
private String userAgent =
- System.getProperty(MagicNames.HTTP_AGENT_PROPERTY,
- DEFAULT_AGENT_PREFIX + "/"
- + Main.getShortAntVersion());
Review Comment:
I agree, I see this is mentioned in the
https://github.com/apache/ant/blob/master/CONTRIBUTING.md
##########
src/main/org/apache/tools/ant/taskdefs/Get.java:
##########
@@ -77,6 +72,7 @@ public class Get extends Task {
private final Resources sources = new Resources();
private File destination; // required
private boolean verbose = false;
+ private boolean progressbar = false;
Review Comment:
Can we not simply replace the dots with a progress bar? So when
verbose="true" show a progress bar instead of dots. Or would some people prefer
the dots? My feeling is that this is not the case but maybe it's good to
discuss this on the dev list, see
https://github.com/apache/ant/blob/master/CONTRIBUTING.md too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
