maartenc commented on code in PR #114:
URL: https://github.com/apache/ant-ivy/pull/114#discussion_r2283085531
##########
test/java/org/apache/ivy/core/module/descriptor/IvyMakePomTest.java:
##########
@@ -32,59 +27,61 @@
import org.apache.ivy.TestHelper;
import org.apache.ivy.ant.IvyMakePom;
import org.apache.ivy.util.TestXmlHelper;
+
import org.apache.tools.ant.Project;
-import org.junit.Before;
+
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
+import static org.apache.commons.io.FileUtils.readFileToString;
+import static org.apache.commons.io.FileUtils.writeLines;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
/**
- * Tests {@link IvyMakePom}
+ * Tests {@link IvyMakePom}.
*/
public class IvyMakePomTest {
- private Project project;
+ private Project project = TestHelper.newProject();
Review Comment:
This isn't the same as creating a new project in a @Before method.
Now, the same project is reused for every IvyMakePom task in the test
methods.
Before, every task had a new project.
I'm not saying this is a problem per se, but why change it? Did it cause
issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
