jaikiran commented on code in PR #219: URL: https://github.com/apache/ant/pull/219#discussion_r2135674468
########## src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java: ########## @@ -150,6 +154,29 @@ public void setEnableStartTLS(boolean b) { this.starttls = b; } + /** + * Set whether to require authentication to switch to a TLS + * connection via STARTTLS. + * + * @param b boolean; if true STARTTLS will be supported and required. + * @since Ant 1.10.16 + */ + public void setRequireStartTLS(boolean b) { + this.requireStarttls = b; + if (b) { + setEnableStartTLS(b); Review Comment: I don't remember either :) But I am almost certain that I had seen a similar thing is a different task a few years back. I'll take a look at the code this week and see if I can find that. But please don't wait until then, the current changes look reasonable to me and it is fine to merge them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org