FROZENCADET commented on code in PR #213:
URL: https://github.com/apache/ant/pull/213#discussion_r1794796178
##########
src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java:
##########
@@ -435,7 +435,8 @@ private String parseUri(final String uri) {
throw new BuildException("no username was given. Can't
authenticate.");
}
- final int indexOfPath = uri.indexOf(':', indexOfAt + 1);
+ // For IPv6 address having more than one ":", it should look for the
last occurrence
+ final int indexOfPath = uri.lastIndexof(':');
if (indexOfPath == -1) {
Review Comment:
I agree.. have made the required changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]