bodewig commented on PR #194: URL: https://github.com/apache/ant/pull/194#issuecomment-1328088190
it seems e04fbe7ff works for our tests. I thought about letting the encoding tell us what a NUL would look like and then search for that, this seems to work even though it was more complex than I hoped for as Java's UTF-16 encoder prepends a BOM to every string, including one only consisting of a NUL. Of course this is slower than the code we had before but parsing tar archive names is not likely to be the performance bottleneck of a build process. And people should not use Ant's tar package but rather switch to Commons Compress outside of the context of Ant itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
