arturobernalg commented on a change in pull request #155:
URL: https://github.com/apache/ant/pull/155#discussion_r716157501
##########
File path: src/main/org/apache/tools/ant/taskdefs/XmlProperty.java
##########
@@ -404,17 +404,14 @@ public Object processNode(Node node, String prefix,
Object container) {
}
String nodeText = null;
boolean emptyNode = false;
- boolean semanticEmptyOverride = false;
- if (node.getNodeType() == Node.ELEMENT_NODE
+ boolean semanticEmptyOverride = node.getNodeType() == Node.ELEMENT_NODE
&& semanticAttributes
&& node.hasAttributes()
&& (node.getAttributes().getNamedItem(VALUE) != null
- || node.getAttributes().getNamedItem(LOCATION) != null
- || node.getAttributes().getNamedItem(REF_ID) != null
- || node.getAttributes().getNamedItem(PATH) != null ||
node.getAttributes()
- .getNamedItem(PATHID) != null)) {
- semanticEmptyOverride = true;
- }
+ || node.getAttributes().getNamedItem(LOCATION) != null
Review comment:
hi @bodewig
Changed.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
