On 2020-09-29, Martijn Kruithof wrote:

> - Fixed 2 typo's found (committed to master)

Thank you.

Fortunately it is easy to fix the online version of the manual, I'll
make sure to include your changes to master when publishing the 1.10.9
manual.

> - should reference to Rhino being available in java 7 runtime be removed from 
> the manual (script.html) and should the system requirements in install be 
> updated to reflect 1.10 series requires jdk 8? (preparing pull request)

We probably have quite a few references to older versions in the manual,
just take a look at the javadoc page which explains which options are
only available in Java 1.2 and above :-)

Given the winded history around JavaScript in Java it may make sense to
reduce the references to versions Ant 1.10 wouldn't work with anyway. So
+1 from me.

> - Should a reference to use Rhino (which has been updated recently) be added 
> as well? it is referenced from a lot of other places on the script manual 
> page?

I haven't looked for cross-links, just realized the scripdef,
scriptfilter and scriptcondition snippets haven't got as many words
about scriptong engine options as the script task page. To me these are
the only places I came up with that might need to talk about
rhino/nashorn/graal at all.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Reply via email to