twogee commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549702330 The rationale for revision of MagicNames/MagicTestNames is threefold: - make the use of special property names/constants explicit; - establish a single definition of property names/constants (there's a duplication between MagicNames and ProjectHelper; a rework may be necessary if MagicNames should be for property names and ProjectHelper for constants only); - BuildFileTest/BuildFileRule should ignore basedir set by Maven when JUnit tests are run by Surefire (like it or not, developers of Ant plugins are using it).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
