jaikiran commented on a change in pull request #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#discussion_r286058434
##########
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java
##########
@@ -157,6 +163,30 @@ public void setFailureProperty(final String
failureProperty) {
public void setPrintSummary(final boolean printSummary) {
this.printSummary = printSummary;
}
+
+ /**
+ * Tags to include. Will trim each tag.
+ *
+ * @param list comma separated list of tags.
+ */
+ public void setIncludeTags(final String includes) {
+ StringTokenizer tokens = new StringTokenizer(includes, ",");
+ while (tokens.hasMoreTokens()) {
+ includeTagList.add(tokens.nextToken().trim());
+ }
+ }
+
+ /**
+ * Tags to exclude. Will trim each tag.
+ *
+ * @param list comma separated list of tags.
+ */
+ public void setExcludeTags(final String excludes) {
Review comment:
Can you add a `@since Ant 1.10.7` to the javadoc of this method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
