Github user bodewig commented on the pull request:

    
https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28691921
  
    In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
    In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java on line 107:
    I'm afraid my Swedish is not up to the task :-)
    Let's make this concrete and then I'll shut up. Assuming the first call to 
`findClass` in the original line 97 throws an exception. Now if the second 
`findClass` in the original line 106 which is now in line 111 does not throw a 
`BuildException` will the new code fail? The old one would because of the 
original line 107.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Reply via email to