On 2018-04-15, <gin...@apache.org> wrote:

> @@ -275,10 +270,7 @@ public class DefaultLogger implements BuildLogger {
>                      new BufferedReader(new 
> StringReader(event.getMessage()))) {

>                      message.append(r.lines().map(line -> prefix + line)
> -                        .collect(Collectors.joining(StringUtils.LINE_SEP)));
> -                    if (message.length() == 0) {
> -                        message.append(prefix);
> -                    }
> +                        .collect(Collectors.joining(System.lineSeparator(), 
> prefix, "")));
>                  } catch (IOException e) {
>                      // shouldn't be possible
>                      message.append(label).append(event.getMessage());

I think this puts the last "prefix" in the wrong position, In the
original code it was appended after the message, the new joining call
puts it before the joined message. The second and third arg of joining
need to be swapped IMHO.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Reply via email to