On 2018-04-01, <gin...@apache.org> wrote:
> http://git-wip-us.apache.org/repos/asf/ant/blob/95495d57/src/main/org/apache/tools/bzip2/BlockSort.java
> ----------------------------------------------------------------------
> diff --git a/src/main/org/apache/tools/bzip2/BlockSort.java
> b/src/main/org/apache/tools/bzip2/BlockSort.java
> @@ -651,7 +648,7 @@ class BlockSort {
> if (onceRun) {
> fmap[j] = a;
> if ((j -= h) <= mj) { //NOSONAR
> - break HAMMER;
> + break;
> }
Whoa. You are touching the scariest code inside of Ant :-)
Reviewing the break and continue changes will take some time.
Have you performed the changes with the help of some tools? Those loops
have been hand-optimized (by somebody who I hope understood the code
better than me) and I'm extremely reluctant to touching it at all.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
