Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/55
ivy-lierre.svg:
- looks good
- havent compared, I think asciidoc/images and doc/images are the same?
- why this name? why not simply logo.svg? (ok, I see: ivy-lierre.png ...)
But there is logo.png with same content (only smaller borders)
ivy-report.css
- seems that here is only different formatting
ivy-report.xsl
- formatting
- changed <img ..gif> to <svg>
- translated img/@art->svg//title and img/@title->svg//title
! couldnt see the content of the grafik (where is defined that
searched/downloaded svg should be used?)
IvyLogo.java
- havent tested that generated code
- JavaDoc of the parameters of IvyLogo(int width, int height) are bad
("ditto")
- I am thinking about the code generation ...
a) include the flamingo task into our build and remove the generated code
(= keep the model (svg) and the generator)
b) just keep that generated code
c) reuse the svg (Java reads the svg-resource and interpretes the drawing)
Because this is one-shot we could go with b) ...
Checked out the code and the report looks fine.
But a simple ivy:report didnt work, I changed build.xml:500 to use
explicitly the new xsl
<ivy:report todir="${ivy.report.dir}"
xslfile="src/java/org/apache/ivy/plugins/report/ivy-report.xsl"/>
Maybe my local environment ...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
