> Le 20 mai 2017 à 04:45, J Pai <jai.forums2...@gmail.com> a écrit : > > This pre-commit job is now almost functional. It gets triggered whenever > there’s a PR and runs the build and tests and reports back if there are any > failures. > > However, the only thing that’s pending or seems to be an issue is it > sometimes doesn’t report back with the status. In these 2 PRs > https://github.com/apache/ant-ivy/pull/19 > https://github.com/apache/ant-ivy/pull/20 the status was never reported back > to github (one of the jobs succeeded and the other failed, so there isn’t a > clear hint of when this happens).
I have seen that. In the config I didn’t see any obvious option that fix that. > Other than that, this entire pre-commit support that was added quickly has > helped a lot. Thanks very much for doing that. > > On a related note, while we are at this - does Apache infra allow the jobs to > be run against Windows OS Jenkins agents as well? There are a few issues > specifically reported against Windows OS and having the job run against linux > and Windows OS should give a decent coverage for the upstream code. In Jenkins there is the concept of « Matrix » job. Here is the ones for Ant: https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-Windows/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-Windows/> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-Linux/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-Linux/> AFAIR, it used to be able to do on several different OS. I don’t know why they are split. And I don’t know if it is possible to do it while pulling a PR from github. Nicolas > > -Jaikiran > > On 18-May-2017, at 4:03 PM, Nicolas Lalevée <nicolas.lale...@hibnet.org> > wrote: > > I have changed the config of the build so it does a build, then checkstyle, > then findbugs, and then the unit tests. > > Nicolas > >> Le 18 mai 2017 à 08:21, J Pai <jai.forums2...@gmail.com> a écrit : >> >> Now that the findbugs URL issue has been resolved with this PR[1] being >> merged, maybe we should change the targets that get run via this pre commit >> job to be just: >> >> ant clean test >> >> and as a start, see how it goes with the PR integration process? >> >> [1] https://github.com/apache/ant-ivy/pull/16 >> <https://github.com/apache/ant-ivy/pull/16> >> >> -Jaikiran >> >> On 17-May-2017, at 6:59 PM, Nicolas Lalevée <nicolas.lale...@hibnet.org >> <mailto:nicolas.lale...@hibnet.org>> wrote: >> >> Seems to be a classpath issue where two ivy.jar are loaded. Considering the >> full console log, probably due to init-ivy called twice, a consequence of >> Ant not computing one unified tree of tasks to call, but a list of trees of >> the tasks on the command line. >> >> The build dedicated to check the style of Ivy is just calling: ant findbugs >> checkstyle-internal >> https://builds.apache.org/view/A/view/Ant/job/Ivy-check >> <https://builds.apache.org/view/A/view/Ant/job/Ivy-check> >> <https://builds.apache.org/view/A/view/Ant/job/Ivy-check >> <https://builds.apache.org/view/A/view/Ant/job/Ivy-check>> >> But it seems broken too due to some broken download link. The init-findbug >> task needs to be fixed. >> >> Nicolas >> >>> Le 17 mai 2017 à 14:11, Jan Matèrne (jhm) <apa...@materne.de> a écrit : >>> >>> My last test result: >>> The Jenkins job could not load Findbugs. So I have deactivated that for the >>> moment. >>> >>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/6/console >>> ant-1.9.9> ant clean jar sources checkstyle-internal coverage-report >>> resolve: >>> BUILD FAILED >>> /.../build.xml:184: java.lang.ClassCastException: >>> org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor cannot be >>> cast to org.apache.ivy.core.module.descriptor.ModuleDescriptor >>> at >>> org.apache.ivy.ant.IvyPostResolveTask.getConfsToResolve(IvyPostResolveTask.java:233) >>> at >>> org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:219) >>> at >>> org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179) >>> at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88) >>> at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272) >>> >>> ant-1.9.9> ant -f build-release.xml -Drat.failOnError=false rat >>> not run due to prior problems >>> >>> >>> Some ideas? >>> >>> >>> Jan >>> >>> >>>> -----Ursprüngliche Nachricht----- >>>> Von: J Pai [mailto:jai.forums2...@gmail.com] >>>> Gesendet: Mittwoch, 17. Mai 2017 13:18 >>>> An: Ant Developers List >>>> Betreff: Re: Ivy - Buildjobs/PreCommit >>>> >>>> Updated the same PR and that triggered this job >>>> https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due >>>> to a host not being resolvable. This job ran on node called H15 >>>> https://builds.apache.org/computer/H15/ whereas the first job which had >>>> succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe >>>> all nodes are not equal and perhaps this job needs to be >>>> assigned/categorized to certain node groups? >>>> >>>> -Jaikiran >>>> On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) <apa...@materne.de> >>>> wrote: >>>> >>>> Thanks, I changed the job to run: >>>> >>>> ant clean jar sources findbugs checkstyle-internal coverage-report ant >>>> -f build-release.xml -Drat.failOnError=false rat >>>> >>>> Please try again ;) >>>> >>>> >>>> Jan >>>> >>>> >>>>> -----Ursprüngliche Nachricht----- >>>>> Von: J Pai [mailto:jai.forums2...@gmail.com] >>>>> Gesendet: Mittwoch, 17. Mai 2017 10:53 >>>>> An: Ant Developers List >>>>> Betreff: Re: Ivy - Buildjobs/PreCommit >>>>> >>>>> It turns out the PR you submitted was to your personal repo instead >>>> of >>>>> the apache repo. I just submitted a dummy PR to apache repo >>>>> https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger >>>>> the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy- >>>>> GithubPR/1/ automagically :) I’m guessing this job isn’t running any >>>>> tests right now (given how quickly it finished)? >>>>> >>>>> This is good start to getting this working. Thanks for getting this >>>>> setup :) >>>>> >>>>> -Jaikiran >>>>> >>>>> >>>>> On 17-May-2017, at 2:07 PM, J Pai <jai.forums2...@gmail.com> wrote: >>>>> >>>>> Doesn’t look like it got triggered in Jenkins. >>>>> >>>>> -Jaikiran >>>>> On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <apa...@materne.de> >>>>> wrote: >>>>> >>>>>> I read the wiki page >>>> https://wiki.apache.org/general/PreCommitBuilds, >>>>>> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and >>>>>> had a look at some other PreCommit-jobs. >>>>>> For me this works like that: >>>>>> 1. The PreCommit-Admin job checks regularly on for new patches in >>>>> Jira. >>>>>> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and >>>>>> file-ID as argument. >>>>>> 3. The job does the rest. >>>>>> >>>>>> That means the job itself has to apply the patchfile - and of course >>>>>> run the build. >>>>>> >>>>>> On the other hand I found a blog post from infra >>>>>> https://blogs.apache.org/infra/entry/github_pull_request_builds_now >>>>>> and set up an according job >>>>>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/ >>>>>> This job uses the Github integration by Cloudbees Enterprise plugin. >>>>>> So next step for test would be a new/updated PR ... >>>>> >>>>> I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1. >>>>> Now ... wait ;) >>>>> >>>>> Jan >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional >>>>> commands, e-mail: dev-h...@ant.apache.org >>>>> >>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional >>>>> commands, e-mail: dev-h...@ant.apache.org >>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional >>>> commands, e-mail: dev-h...@ant.apache.org >>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional >>>> commands, e-mail: dev-h...@ant.apache.org >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org >>> For additional commands, e-mail: dev-h...@ant.apache.org >>> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org >> <mailto:dev-unsubscr...@ant.apache.org> >> For additional commands, e-mail: dev-h...@ant.apache.org >> <mailto:dev-h...@ant.apache.org> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org >
